The test for ISmbiosInformationStatics_get_SerialNumber is broken on Window 10 testbot VMs, presumably because they don't have a serial number? It results in an HRESULT of E_UNEXPECTED. I added a broken test case for it. I'm assuming that normal installations of Windows return a valid serial number or at least something like "Not Specified" and not NULL. Also, on my Linux OS running cat /sys/class/dmi/id/product_serial returns "To be filled by O.E.M". So I added a fallback to return 0 as the number. Or is it fine to just return whatever string is found?
On the Windows 8 VMs, the test crashes at line 75, hr = ISmbiosInformationStatics_get_SerialNumber( smbios_statics, &serial ). Not sure what I should do in this case. I was hoping for a flag that checks if the VM is Windows 8, but there doesn't seem to be one. Should I wrap the test in if (0) or is there an alternative way?
Another weird thing is the test fails prematurely on only the 32-bit version of debian11b, saying that the runtimeclass is not registered. I'm assuming it's an issue with the testbot. Debian11 32 bit runs fine.
--
v2: windows.system.profile.systemmanufacturers: Implement ISmbiosInformationStatics_get_SerialNumber.
wbemprox: Provide accurate SMBIOS serial number.
windows.system.profile.systemmanufacturers/tests: Add ISmbiosInformationStatics_get_SerialNumber tests.
windows.system.profile.systemmanufacturers: Stub ISmbiosInformationStatics interface.
windows.system.profile.systemmanufacturers: Add stub DLL.
https://gitlab.winehq.org/wine/wine/-/merge_requests/1588
--
v2: joy.cpl: Remove unnecessary JoystickData structure.
joy.cpl: Move dinput test tab logic to dinput.c.
joy.cpl: Draw dinput axes state with gdi32.
joy.cpl: Draw dinput button state with gdi32.
joy.cpl: Add a checkbox to test xinput rumble.
joy.cpl: Draw xinput controller state with gdi32.
joy.cpl: Add a new xinput controller test tab.
joy.cpl: Build without NONAMELESSUNION.
joy.cpl: Use designated initializers in display_cpl_sheets.
joy.cpl: Add DI_ prefix to dinput dialog constants.
https://gitlab.winehq.org/wine/wine/-/merge_requests/1609
This prevents a deadlock between the window data lock and the ntdll loader lock because
sync_window_cursor() eventually may grab the ntdll loader lock. So if another thread already
grabbed the ntdll loader lock and wants to enter the same window data critical section, it will
deadlock.
Fix Youropa (SteamID: 640120) OpenGL launch option launching to a black screen.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/1607
The test for ISmbiosInformationStatics_get_SerialNumber is broken on Window 10 testbot VMs, presumably because they don't have a serial number? It results in an HRESULT of E_UNEXPECTED. I added a broken test case for it. I'm assuming that normal installations of Windows return a valid serial number. Also, on my Linux OS running cat /sys/class/dmi/id/product_serial returns "To be filled by O.E.M". So I added a fallback to return 0 as the number. Or is it fine to just return whatever string is found?
On the Windows 8 VMs, the test crashes at line 75, hr = ISmbiosInformationStatics_get_SerialNumber( smbios_statics, &serial ). Not sure what I should do in this case. I was hoping for a flag that checks if the VM is Windows 8, but there doesn't seem to be one. Should I wrap the test in if (0) or is there an alternative way?
Another weird thing is the test fails prematurely on only the 32-bit version of debian11b, saying that the runtimeclass is not registered. I'm assuming it's an issue with the testbot. Debian11 32 bit runs fine.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/1588