- wine-gitlab - winehq.org

[PATCH 0/1] MR750: winecrt0: remove free_delay_imports.
by Kevin Puetz (＠puetzk) 31 Aug '22

31 Aug '22

MSVC's delayimp.lib does not actually free delayload dependencies. winecrt0's attempt to do so from ELF __attribute__((destructor)) is unnecessary and potentially harmful: - When triggered naturally via LdrUnloadDll, this leads to recursive calls to FreeLibrary, violating free_lib_count and missing DLL_PROCESS_DETACH - when triggered by glibc's _dl_fini (at process exit), it leads to use-after-free of the TEB (GetCurrentThreadID after the main thread is no longer Win32) via FreeLibrary -> LdrLdrUnloadDll -> RtlEnterCriticalSection( &loader_section ) - double-free of the library itself, since the DLL_PROCESS_DETACH has already been handled by LdrShutdownProcess - Race against wineserver sending a SIGKILL from process_killed, since all Win32 threads of the process have exited Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53032 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/750

2 2

Re: [PATCH v3 0/2] MR747: dinput: Remove WINAPI on static functions where not needed. - approved
by Rémi Bernon (＠rbernon) 31 Aug '22

31 Aug '22

This merge request was approved by R��mi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/747

1 0

[PATCH 0/1] MR748: crypt32: Remove WINAPI on static functions where not needed.
by Francois Gouget (＠fgouget) 31 Aug '22

31 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/748

2 1

[PATCH v3 0/1] MR745: ntdll: Improve stub of NtQueryEaFile.
by Joel Holdsworth (＠jhol) 31 Aug '22

31 Aug '22

Based on a patch by Qian Hong. -- v3: ntdll: Improve stub of NtQueryEaFile. https://gitlab.winehq.org/wine/wine/-/merge_requests/745

2 1

Re: [PATCH 0/0] MR747: dinput: Remove WINAPI on static functions where not needed. - closed
by Francois Gouget (＠fgouget) 31 Aug '22

31 Aug '22

This merge request was closed by Francois Gouget. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/747

1 0

Re: [PATCH v2 0/1] MR744: winealsa.drv: Make functions static where possible.
by Huw Davies (＠huw) 31 Aug '22

31 Aug '22

Huw Davies (@huw) commented about dlls/winealsa.drv/alsa.c: > return key; > } > > -ULONG reg_query_value( HKEY hkey, const WCHAR *name, > +static ULONG reg_query_value( HKEY hkey, const WCHAR *name, > KEY_VALUE_PARTIAL_INFORMATION *info, ULONG size ) Could you correctly indent the second line? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/744#note_7335

1 0

[PATCH 0/1] MR746: static winex11
by Francois Gouget (＠fgouget) 31 Aug '22

31 Aug '22

- kernelbase: Fix error value for PE files without resource. - include: Simplify handling of va_list in debug printf functions. - include: Add va_list version of the debug printf functions. - include: Avoid _t-suffixes. - include: Add list_move_after() and list_move_before(). - user32: Call winproc_init before dpiaware_init. - combase: Omit thread ID from the stub manager ipid for MTA objects. - d3dx10: Factor out image format conversion function. - d3dx10: Use WIC functions to obtain info about DDS image. - d3dx10: Add support for texture cubes in D3DX10CreateTexture functions. - d3dx10: Don't check frame count in load_texture_data. - d3dx10: Add support for loading MipLevels data in load_texture_data. - d3dx10/tests: Improve cube textures data testing. - winemac.drv: Rename display modes cache variables. - winemac.drv: Invalidate mode cache when enum flags changes. - winemac.drv: Remove unnecessary macdrv_EnumDisplaySettingsEx declaration. - winemac.drv: Check for non-primary adapter earlier in macdrv_ChangeDisplaySettingsEx. - winemac.drv: Support getting non-primary adapter current display mode. - winemac.drv: Support enumerating non-primary adapters display modes. - evr/filter: Implement pin's connect/disconnect. - d3dx10: Implement D3DX10PreprocessShaderFromMemory(). - d3dx10/tests: Add a test for D3DX10PreprocessShaderFromMemory(). - wmvcore/tests: Use a constant for test.wmv duration. - wmvcore/tests: Test sync reader output settings read / write. - wmvcore/tests: Test async reader output settings read / write. - wmvcore/tests: Test that the callback thread is always the same. - wmvcore/tests: Test async reader compressed sample monotonic pts. - wmvcore/tests: Test async reader DedicatedDeliveryThread setting. - mshtml/tests: Fix a spelling error in an ok() message. - dbghelp: Fix a couple of spelling errors in a comment. - mscvpdb: Fix a spelling error in a comment. - winspool.drv/tests: Fix the spelling of a variable name. - winex11.drv: Make get_unix_file_name() static. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/746

2 1

Re: [PATCH v5 0/11] MR7: vkd3d-shader/hlsl: Translate copy propagation to index paths. Check for non-static object references. Implicit array initialization.
by Giovanni Mascellani (＠giomasce) 31 Aug '22

31 Aug '22

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_codegen.c: > > static void copy_propagation_invalidate_whole_variable(struct copy_propagation_var_def *var_def) > { > + unsigned int component_count = hlsl_type_component_count(var_def->var->data_type); > unsigned i; > > TRACE("Invalidate variable %s.\n", var_def->var->name); > > - for (i = 0; i < var_def->var->data_type->reg_size; ++i) > + for (i = 0; i < component_count; ++i) > var_def->values[i].state = VALUE_STATE_DYNAMICALLY_WRITTEN; > } > > -static void copy_propagation_set_value(struct copy_propagation_var_def *var_def, unsigned int offset, > - unsigned char writemask, struct hlsl_ir_node *node) > +static void copy_propagation_set_value(struct copy_propagation_var_def *var_def, unsigned int comp, For the future, please do code cleaning stuff (like renaming variables) in dedicated commits, so that the "meaty" commits are easier to read. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/7#note_7330

1 0

[PATCH 0/1] MR745: ntdll: Improve stub of NtQueryEaFile.
by jhol (＠jhol) 31 Aug '22

31 Aug '22

Based on a patch by Qian Hong. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/745

2 1

[PATCH 0/7] MR743: static
by Francois Gouget (＠fgouget) 31 Aug '22

31 Aug '22

- kernelbase: Fix error value for PE files without resource. - include: Simplify handling of va_list in debug printf functions. - include: Add va_list version of the debug printf functions. - include: Avoid _t-suffixes. - include: Add list_move_after() and list_move_before(). - user32: Call winproc_init before dpiaware_init. - combase: Omit thread ID from the stub manager ipid for MTA objects. - d3dx10: Factor out image format conversion function. - d3dx10: Use WIC functions to obtain info about DDS image. - d3dx10: Add support for texture cubes in D3DX10CreateTexture functions. - d3dx10: Don't check frame count in load_texture_data. - d3dx10: Add support for loading MipLevels data in load_texture_data. - d3dx10/tests: Improve cube textures data testing. - winemac.drv: Rename display modes cache variables. - winemac.drv: Invalidate mode cache when enum flags changes. - winemac.drv: Remove unnecessary macdrv_EnumDisplaySettingsEx declaration. - winemac.drv: Check for non-primary adapter earlier in macdrv_ChangeDisplaySettingsEx. - winemac.drv: Support getting non-primary adapter current display mode. - winemac.drv: Support enumerating non-primary adapters display modes. - evr/filter: Implement pin's connect/disconnect. - d3dx10: Implement D3DX10PreprocessShaderFromMemory(). - d3dx10/tests: Add a test for D3DX10PreprocessShaderFromMemory(). - wmvcore/tests: Use a constant for test.wmv duration. - wmvcore/tests: Test sync reader output settings read / write. - wmvcore/tests: Test async reader output settings read / write. - wmvcore/tests: Test that the callback thread is always the same. - wmvcore/tests: Test async reader compressed sample monotonic pts. - wmvcore/tests: Test async reader DedicatedDeliveryThread setting. - mshtml/tests: Fix a spelling error in an ok() message. - dbghelp: Fix a couple of spelling errors in a comment. - mscvpdb: Fix a spelling error in a comment. - winspool.drv/tests: Fix the spelling of a variable name. - winealsa.drv: Make functions static where possible. - winex11.drv: Make get_unix_file_name() static. - dinput: Remove WINAPI on static functions where not needed. - dinput/tests: Remove WINAPI on static functions where not needed. - crypt32: Remove WINAPI on static functions where not needed. - windows.media.speech: Remove WINAPI on static functions where not needed. - winexinput.sys: Remove WINAPI on static functions where not needed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/743

2 8

2025

2024

2023

2022

wine-gitlab