A much cleaner result (written by hand) that we can reuse where needed later (_i.e._ `GetNumaProcessorNode` which also crashes with [a similar MAV](https://gist.github.com/wasertech/f894ce8d6250e72a01a861c0e4eb6064) on multi-node systems).
Took me a while to understand where I should put everything, not even sure I got it right. Let me know.
I thought I was going to need `FileNumaNodeInformation` but turns out it's not really needed. I can remove it if you want.
This is what I see when I try to get a node count read:
```log
0024:fixme:ntdll:init_numa_info node affinity; using node 0.
GetNumaHighestNodeNumber: 1
```
I only see this fixme if I try to access `FILE_NUMA_NODE_INFORMATION`. I would really prefer such a behavior for our compatibility layer on any multi-node system.
A big thanks to @besentv and @zfigura for their invaluable feedback on this.
--
v6: kernel32/tests: fix parameter type in pGetNumaHighestNodeNumber and improve test messages
ntdll: improve return handling in init_numa_info and fix parameter checking
https://gitlab.winehq.org/wine/wine/-/merge_requests/8995
--
v3: iphlpapi: Try to disambiguate addresses in GetBestRoute2() by probing system assigned ones.
iphlpapi/tests: Add tests for best routes.
iphlpapi: Reimplement GetBestInterfaceEx() on top of GetBestRoute2().
iphlpapi: Implement GetBestRoute2().
https://gitlab.winehq.org/wine/wine/-/merge_requests/8991
This is part XXXV of cmd engine rewrite.
It :
- fixes a regression introduced by previous serie,
- fixed a couple of erroneous settings of some env variables
(likely corner cases)
But mostly, it's the start of implementing a pipe (between commands)
as a pipe (IPC).
Currently, cmd runs lhs of pipe, stores output into a file, then
runs rhs with that file as input.
However, this will expose a bunch of issues to be fixed before
thinking implementing the IPC part.
This serie covers the output part:
- don't filter the stderr output in the paging (MORE) output,
- send all stdout output to the paging (MORE),
- use a line-buffered output for stdout,
- adding some explicit flush before expecting input.
It also fixes an issue triggered down the road.
Next series (likely two) will cover the input part.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/9011
Implement test cases for `IXMLDOMElement_removeAttributeNode()`
function. Cover the successful removal and failure codes for double
removal and `NULL` pointer removal.
The function is currently unimplemented in wine.
This is the recommended first step according to the contribution
documentation (do coverage MR first, then implementation MR).
WineTestBot submission can be found here:
https://testbot.winehq.org/JobDetails.pl?Key=159816
Once this one is merged I'll create the implementation MR.
I tried to match the formatting. If I've missed something please tell me and I'll fix it.
edit: remove mention of failing tests, update WineTestBot link, fixed by rebasing on 3cfbf9e3cd99dd01d3215c6952ae18ce88207d22
--
v6: msxml3/tests: add test for IXMLDOMElement_removeAttributeNode.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8928
Add support for D3DFMT_CxV8U8, which is required for the game Biorage.
Also add support for loading DDS files with header flag values of `DDS_PF_FOURCC` alongside other flag values.
--
v3: d3dx11/tests: Add more DDS pixel format tests.
d3dx10/tests: Add more DDS pixel format tests.
d3dx9: Ignore all other DDS pixel format flags if DDS_PF_FOURCC is set.
d3dx9/tests: Add a test for DDS_PF_FOURCC flag handling.
d3dx9/tests: Add tests for ATI{1,2} DDS files.
d3dx9: Replace D3DFMT_CxV8U8 with D3DFMT_X8L8V8U8 when creating textures.
d3dx9: Add support for D3DFMT_CxV8U8.
d3dx9/tests: Add tests for D3DFMT_CxV8U8.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8966