[PATCH v8 12/14] ntdll: improve return handling in init_numa_info and fix parameter checking

[wasertech]

From: wasertech

---
 dlls/ntdll/unix/system.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/dlls/ntdll/unix/system.c b/dlls/ntdll/unix/system.c
index 7e5cbbf9cb2..733ae15e87a 100644
--- a/dlls/ntdll/unix/system.c
+++ b/dlls/ntdll/unix/system.c
@@ -1409,15 +1409,15 @@ NTSTATUS init_numa_info(FILE_NUMA_NODE_INFORMATION *info)
     unsigned int i;

if (!info) { return STATUS_INVALID_PARAMETER; }
-    if (pthread_once(&logical_proc_init_once, init_logical_proc_info) != 0) {
-        return STATUS_UNSUCCESSFUL;
-    }
+    if (pthread_once(&logical_proc_init_once, init_logical_proc_info) != STATUS_SUCCESS) 
+        { return STATUS_UNSUCCESSFUL; }

info->HighestNodeNumber = 0;
     info->NodeNumber = 0;
     info->Reserved = 0;

-    if (logical_proc_info_len > 0 && !logical_proc_info) { return STATUS_UNSUCCESSFUL; }
+    if (logical_proc_info_len > STATUS_SUCCESS && !logical_proc_info)
+        { return STATUS_UNSUCCESSFUL; }

for (i = 0; i < logical_proc_info_len; ++i)
     {
@@ -1429,7 +1429,9 @@ NTSTATUS init_numa_info(FILE_NUMA_NODE_INFORMATION *info)
     }

info->NodeNumber = 0;
-    if (info->HighestNodeNumber > info->NodeNumber) { FIXME( "node affinity; using only node %u.\n", info->NodeNumber ); }
+    if (info->HighestNodeNumber > info->NodeNumber)
+        { FIXME( "node affinity; using only node %u.\n", info->NodeNumber ); }
+    
     return STATUS_SUCCESS;
 }