Re: [PATCH v8 0/5] MR9112: XCOPY and COPY should not attempt to copy a file to itself.

[eric pouech (＠epo)]

eric pouech (@epo) commented about programs/xcopy/xcopy.c:
>                         copyFrom, copyTo, error);
>                  XCOPY_FailMessage(error);
>
> -
>                if (flags & OPT_IGNOREERRORS) {
> -
>                    skipFile = TRUE;
> -
>                } else {
> -
>                skipFile = TRUE;
> -
>                if (!(flags & OPT_IGNOREERRORS)) {
>                    ret = RC_WRITEERROR;
> -
>                    goto cleanup;

good catch for the resource leak that gets fixed

but that could even deserve a separate commit in the MR as this is orthogonal to the rest of the changes