On Thu Sep 25 07:31:33 2025 +0000, James McDonnell wrote:
Please review the svg changes again.
Great progress indeed. A couple of points I spotted:
* The 4-bit icons need to use only colors from the [16-color VGA palette](https://en.wikipedia.org/wiki/List_of_8-bit_computer_hardware_graphics#/medi...). * The 4 and 8-bit icons need to be paletted, rather than RGB. * In the 16-4 image, it looks to me that the bottom right of the shield could use some tidy up in the pixel art. It looks slightly jagged. * The 48-32, 32-32 and 16-32 icons are raster images. These should be a vector images (the 16-32 is sometimes raster in some of the other icons). It is important to keep the lines properly aligned to the pixel grid to prevent blurriness with 1px thickness. Are these included in the Tango sources? This would have been done in the original Tango source, but if the size you need is not available, you can achieve the same thing by tweaking the geometry. If you look at the other Wine icons and turn on a pixel grid in Inkscape, you will see how they have been aligned to the pixel grid. * The 48-8 and 48-4 images do not have the ids attributes set, so they won't render out. * The 256-32 image (and 48-32, 32-32 and 16-32 vector images that I am requesting), do not have the invisible rectangle element with the id set to `<rect id="icon:32-32" height="32" width="32" y="236" x="440" style="fill:none" />`, so they won't render out either.
[control.svg](https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/shell32/resources/con...) demonstrates these points most clearly.
I know this is all very pedantic, but it's necessary to achieve best results. You can understand why my [original Tango icons project](https://www.omgubuntu.co.uk/2010/05/wine-icon-facelift-on-target-for-june-lo...) took around 14-months to complete! I thought it would be done in a weekend.