On Fri Sep 26 08:54:11 2025 +0000, eric pouech wrote:
every single commit in the MR shall pass all the tests I don't see any todo_wine in the first commit, so either the tests don't cover the changes you're making, or you forgot to add the todo_wine to the first commit (and the passing ones shall be removed in the second commit)
I don't think you understand what the code change does. My first tests were better. You didn't like those, and wanted me to change them. The current tests will pass both before and after my changes. The problem wasn't that /O parameters specified in DIRCMD didn't work. The problem was that if /O was specified in DIRCMD then /O specified at the command line would not override the one specified in DIRCMD. I will change the tests once more so that they are correct, and I will add and remove the todo_wine bits as you require.