On Fri Sep 26 14:16:34 2025 +0000, Reinhold Gschweicher wrote:
as this is my first real code contribution to Wine I'm a bit lost on how to move this MR forward. Could you provide me some guidance how to tackle this? Should I add a `IXMLDOMNamedNodeMap_removeItemNode` function and call that instead of `IXMLDOMNamedNodeMap_removeNamedItem`? As alternative: for debugging I had a "for each attribute print attribute name" loop. I could re-add that and check name+value to match the attribute and somehow reimplement the "remove Attribute" code (although I failed to do that already, so I went to use `IXMLDOMNamedNodeMap_removeNamedItem` as a workaround)
What I mean is that removing a node likely implies that node is actually is linked already to this element, as an attribute. Every msxml3 node will have a corresponding libxml2 node linked to it. To access that you can use get_node_obj(msxmlnode)->node.node or something similar. My understanding is that such check will help with extra conditions that you have now. And yes, it's not the most straightforward thing to read, which mostly comes from an attempt to reconcile libxml2 and msxml differences.