Re: [PATCH v2 0/2] MR8984: ntdll: Check signal access rights for inproc syncs.

[Alexandre Julliard (＠julliard)]

Alexandre Julliard (@julliard) commented about server/inproc_sync.c:
>  inproc_sync_destroy,        /* destroy */
>
> };
>
> -struct inproc_sync *create_inproc_event_sync( int manual, int signaled )
> +struct inproc_sync *create_inproc_internal_sync( int manual, int signaled )
>  {
>      struct ntsync_event_args args = {.signaled = signaled, .manual = manual};
>      struct inproc_sync *event;
>  if (!(event = alloc_object( &inproc_sync_ops ))) return NULL;
> - event->type = INPROC_SYNC_EVENT;
> - event->type = INPROC_SYNC_INTERNAL;
> event->fd = ioctl( get_inproc_device_fd(), NTSYNC_IOC_CREATE_EVENT, &args );
> - assert( event->fd != -1 );

assert() is not appropriate here, please handle errors properly.