Re: [PATCH v18 0/3] MR8367: shell32: Add shield icon.

[Elizabeth Figura (＠zfigura)]

On Mon Sep 29 03:57:10 2025 +0000, James McDonnell wrote:
> I have added a check for the result being non-zero. Should this be a todo?
>         todo_wine_if(sii->hIcon == 0) {
>             ok(sii->hIcon != 0,
>                 "%3d: got %p, should be non-zero handle\n",
>                 i, sii->hIcon);
>         }
>
> I guess this particular if would have to be a list of the missing id's.
> Otherwise this would not work if someone actually added the missing icons.

It should be a todo in any commit where the behaviour on Wine differs from Windows. Also, don't do "todo_wine_if (a) ok (!a)" unless absolutely necessary; writing it like that means you can't notice if the code changes to fix or break the test. Just write "todo_wine" if possible.