Re: [PATCH v2 0/3] MR8760: mmdevapi: Add support for storing/retrieving more variant types from the device property store.

[Huw Davies (＠huw)]

Huw Davies (@huw) commented about dlls/mmdevapi/devenum.c:
> -
>    default:
> -
>        return 0;
> - }
>
> +}
> -
>
> +static BOOL is_valid_serialized_reg_prop(BYTE *data, DWORD data_size)
> +{
> - struct reg_prop_serialized *reg_prop;
> - unsigned int elem_size;
> -
> - if (data_size <= sizeof(*reg_prop))
> -
>    return FALSE;
> -
> - reg_prop = (struct reg_prop_serialized *)data;
> - if (reg_prop->unk != WINE_REG_PROP_MAGIC)
> -
>    return FALSE;

This seems a bit fragile; if something saved in the existing blob format happens to match here, we'll do the wrong thing.