On Fri Sep 26 08:10:03 2025 +0000, Nikolay Sivov wrote:
I suspect it should be stricter and check that attribute node is actually has "this" as a parent (currently we can't easily check that using API, so it likely should be done and xmlNode level). This also should fix your S_FALSE -> E_INVALIDARG fixup.
as this is my first real code contribution to Wine I'm a bit lost on how to move this MR forward. Could you provide me some guidance how to tackle this?
Should I add a `IXMLDOMNamedNodeMap_removeItemNode` function and call that instead of `IXMLDOMNamedNodeMap_removeNamedItem`?
As alternative: for debugging I had a "for each attribute print attribute name" loop. I could re-add that and check name+value to match the attribute and somehow reimplement the "remove Attribute" code (although I failed to do that already, so I went to use `IXMLDOMNamedNodeMap_removeNamedItem` as a workaround)