Re: [PATCH v10 0/4] MR9010: cfgmgr32: Device query API part 5: Implement support for logical boolean operators in DEVPROP_FILTER_EXPRESSION.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/windows.devices.enumeration/tests/devices.c:
>      if (FAILED( hr ) || FAILED( test_case->start_hr )) goto next;
>
>      ret = WaitForSingleObject( enumerated_data.event, 500 );
> -
>    todo_wine_if( todo_wait ) ok( !ret, "WaitForSingleObject returned %lu\n", ret );
> -
>    /* Enumeration may take a long time on native if there are many device interfaces. */
> -
>    todo_wine_if( todo_wait ) ok( !ret || broken( ret == WAIT_TIMEOUT ), "WaitForSingleObject returned %lu\n", ret );

Increasing the timeout might be better, or maybe reducing what the callback does. I think winetest checks are fairly expensive, especially when something is being printed. If they are taking too long then maybe collecting devices in a collection and running tests separately is better.