Re: [PATCH 0/2] MR9049: winemac.drv: Don't crash when a window with a GL context is minimized

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winemac.drv/opengl.c:
> -
> - if (NtUserGetWindowLongW(hwnd, GWL_STYLE) & WS_MINIMIZE)
> - {
> -
>    /* NtUserGetClientRect will return a zero rect for minimized windows, so
> -
>       we have to get creative. */
> -
>    WINDOWPLACEMENT placement;
> -
>    if (!NtUserGetWindowPlacement(hwnd, &placement))
> -
>        return CGRectNull;
> -
>    window_rect_to_client(hwnd, &placement.rcNormalPosition);
> -
>    return cgrect_from_rect(placement.rcNormalPosition);
> - }
> -
> - if (NtUserGetClientRect(hwnd, &rect, NtUserGetDpiForWindow(hwnd)))
> -
>    return cgrect_from_rect(rect);
> -
> - return CGRectNull;

I think it would be better if we could avoid doing that, is it useful to have a non-empty rect for minimized windows? Is the window content still visible somehow? Could we keep track of non-minimized client window rect, instead of having to query and try reconstructing it with AdjustWindowRect?