[PATCH v2 0/1] MR8998: vbscript: Allow redim without a prior dim.

[Elizabeth Figura (＠zfigura)]

--
  v2: vbscript: Allow redim without a prior dim.

https://gitlab.winehq.org/wine/wine/-/merge_requests/8998

[PATCH v2 1/1] vbscript: Allow redim without a prior dim.

[Francis De Brabandere]

From: Francis De Brabandere

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53767
---
 dlls/vbscript/interp.c       | 6 +++++-
 dlls/vbscript/tests/lang.vbs | 5 +++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/dlls/vbscript/interp.c b/dlls/vbscript/interp.c
index 937cdaf1c8c..127fcc2c05e 100644
--- a/dlls/vbscript/interp.c
+++ b/dlls/vbscript/interp.c
@@ -1316,7 +1316,11 @@ static HRESULT interp_redim(exec_ctx_t *ctx)
         return hres;
     }

-    if(ref.type != REF_VAR) {
+    if(ref.type == REF_NONE) {
+        hres = add_dynamic_var(ctx, identifier, FALSE, &ref.u.v);
+        if(FAILED(hres))
+            return hres;
+    }else if(ref.type != REF_VAR) {
         FIXME("got ref.type = %d\n", ref.type);
         return E_FAIL;
     }
diff --git a/dlls/vbscript/tests/lang.vbs b/dlls/vbscript/tests/lang.vbs
index 0307dbe1c42..0025bfeddcf 100644
--- a/dlls/vbscript/tests/lang.vbs
+++ b/dlls/vbscript/tests/lang.vbs
@@ -1701,6 +1701,11 @@ e = err.number
 on error goto 0
 ok e = 9, "e = " & e ' VBSE_OUT_OF_BOUNDS, can only change rightmost dimension

+redim undeclared_array(3)
+ok ubound(undeclared_array) = 3, "ubound(undeclared_array) = " & ubound(undeclared_array)
+undeclared_array(3) = 10
+ok undeclared_array(3) = 10, "undeclared_array(3) = " & undeclared_array(3)
+
 sub TestReDimFixed
     on error resume next

[Elizabeth Figura (＠zfigura)]

On Sat Sep 20 01:19:03 2025 +0000, Elizabeth Figura wrote:
> changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/8998/diffs?diff_id=210931&start_sha=eb35335a95564ec45d3641fbf712588d41eae4e3#19b309798e74fb8c8af366e0c6cc686d79a38532_1320_1320)

Whoops, I should have seen that. Fixed in v2.

[PATCH v2 0/1] MR8998: vbscript: Allow redim without a prior dim. - approved

[Jacek Caban (＠jacek)]

This merge request was approved by Jacek Caban.