16-color VGA palette
I kind of just assumed the color palette would have been handled by gimp's ico export. So when I imported it into inkscape it would be correct. Which is why everything was a raster.
These should be a vector images
I did not find a svg for the 16x16 icon. Just a png. Maybe I didn't look hard enough.
prevent blurriness
I had to delete most of the feathered edge and put in a hard border for this icon to look remotely nice. The 16x16 icon did not want to export to ico well, hence why the right looks slightly different than the left. It even seemed to look different between different exports.
I didn't think the 256 image was even exported...
Yeah I thought this MR would just have been a quick (load some obvious 'missing' icon if the other icon is not present). I barely can get myself to work on this ticket, as it is rather frustrating when you try to match examples of existing source, to be told don't do it that way, because "I don't like it that way". And my prior patches have been asked for extensive changes, tests, etc, then someone else submits the EXACT same diff, and it passes with no commentary.
-
James McDonnell (＠ElementalWarrior)