[PATCH 0/1] MR9079: win32u/tests: Do not try to modify constant file name in d3dkmt.c:run_in_process_().

[Paul Gofman (＠gofman)]

Fixes a crash in tests run (e. g., https://gitlab.winehq.org/wine/wine/-/jobs/193475).

[PATCH 1/1] win32u/tests: Do not try to modify constant file name in d3dkmt.c:run_in_process_().

[Paul Gofman]

From: Paul Gofman

---
 dlls/win32u/tests/d3dkmt.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/dlls/win32u/tests/d3dkmt.c b/dlls/win32u/tests/d3dkmt.c
index 06d04f82dfd..120e936b88d 100644
--- a/dlls/win32u/tests/d3dkmt.c
+++ b/dlls/win32u/tests/d3dkmt.c
@@ -73,11 +73,13 @@ static void run_in_process_( const char *file, int line, const char *args )
     char cmdline[MAX_PATH * 2], test[MAX_PATH], *tmp, **argv;
     STARTUPINFOA startup = {.cb = sizeof(STARTUPINFOA)};
     PROCESS_INFORMATION info = {0};
-    const char *name;
+    char name_buf[MAX_PATH];
+    char *name = name_buf;
     DWORD ret;
     int argc;

-    name = file;
+    strcpy( name, file );
+
     if ((tmp = strrchr( name, '\' ))) name = tmp;
     if ((tmp = strrchr( name, '/' ))) name = tmp;
     if ((tmp = strrchr( name, '.' ))) *tmp = 0;

[Rémi Bernon (＠rbernon)]

I think this has been fixed with 30c7d4d4573bbb0bc45cf37f1d7c96008e8099bc already

[Paul Gofman (＠gofman)]

Oh... looks like I maybe ended up with a bit stale tree locally somehow where I was reproducing the crash (looks fixed indeed). But why it crashes then in the linked run which is from a few minutes ago?

[William Horvath (＠whrvt)]

On Tue Sep 30 16:13:52 2025 +0000, Paul Gofman wrote:
> Oh... looks like I maybe ended up with a bit stale tree locally somehow
> where I was reproducing the crash (looks fixed indeed). But why it
> crashes then in the linked run which is from a few minutes ago?

The tree that the tests are running on don't contain the commit. It's 38 commits behind current master.

[Paul Gofman (＠gofman)]

On Tue Sep 30 16:13:52 2025 +0000, William Horvath wrote:
> The tree that the tests are running on don't contain the commit. It's 38
> commits behind current master.

Thanks, sorry for the noise.

[PATCH 0/1] MR9079: win32u/tests: Do not try to modify constant file name in d3dkmt.c:run_in_process_(). - closed

[Paul Gofman (＠gofman)]

This merge request was closed by Paul Gofman.