http://bugs.winehq.org/show_bug.cgi?id=421
--- Comment #366 from max(a)veneto.com 2010-05-25 17:00:04 ---
> Well, I understand you did a dirty hack, so I was hoping I could help you (or
> someone trying to locate the problem) to find it. It might be a bug with wine,
> isn't it true?
>
> Are you sure this is not the bad commit? I don't see what I have done wrong. I
> did a git reset --hard f2b993d414517037cf064e9aed954cdae96646f5, patched,
> compiled, and tested, it crashes. The commit before that is
> 5532927ed33f3682c48bdc2a2528488eeefa5bad (according to git log), so I reseted
> to it, patched, compiled, tested and it works.
>
> And I've just tested it again.
>
> Here is the sequence of commands (careful, it deletes WINEPREFIX):
>
> export WINEPREFIX=/home/gugamilare/.wine-test/
> rm -rf dlls/winedib.drv/
> git checkout -f
> make clean
> git reset --hard f2b993d414517037cf064e9aed954cdae96646f5
> sh patches/series # I transformed the file "series" of the tarball into a
> script
> autoconf
> CC="ccache gcc" ./configure && make depend && make
> rm -rf $WINEPREFIX
> ./wine notepad # => works
> rm -rf $WINEPREFIX
> WINEDIB=ON ./wine notepad # => crashes
>
> rm -rf dlls/winedib.drv/
> git checkout -f
> make clean
> git reset --hard 5532927ed33f3682c48bdc2a2528488eeefa5bad
> sh patches/series
> autoconf
> CC="ccache gcc" ./configure && make depend && make
> rm -rf $WINEPREFIX
> WINEDIB=ON ./wine notepad # => works
uhmmmm.... it would be weird. I'll check it on week end.... but the patch seems
to me unrelated to the bug.... or it may expose a previous bug in dib engine.
Your test seems correct to me, indeed.
Could you add a trace of StretchDIBits() parameters in both cases (with and
without the offending patch) ?
Max
Max
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=421
--- Comment #365 from Gustavo <gugamilare(a)gmail.com> 2010-05-25 15:52:52 ---
(In reply to comment #364)
> (In reply to comment #363)
> > Ok, I've redone the regression test. It seems I had forgotten to patch the
> > source in the last 2 tests. I missed by a few commits only, so I did it by
> > hand.
> >
> > The bad commit is f2b993d414517037cf064e9aed954cdae96646f5
> >
> > commit f2b993d414517037cf064e9aed954cdae96646f5
> > Author: Alexandre Julliard <julliard(a)winehq.org>
> > Date: Fri May 14 20:19:58 2010 +0200
> >
> > comctl32/imagelist: Pre-multiply the colors by the alpha channel when
> > storing an image with alpha.
>
> mhhhh.... I guess that's not the right offending patch either.
> It should be somewhere in gdi32/winex11.drv.
> Anyways I posted a working version of the engine.... hopefully. For me it
> works,
> even if I had no time to locate the true problem.
>
Well, I understand you did a dirty hack, so I was hoping I could help you (or
someone trying to locate the problem) to find it. It might be a bug with wine,
isn't it true?
Are you sure this is not the bad commit? I don't see what I have done wrong. I
did a git reset --hard f2b993d414517037cf064e9aed954cdae96646f5, patched,
compiled, and tested, it crashes. The commit before that is
5532927ed33f3682c48bdc2a2528488eeefa5bad (according to git log), so I reseted
to it, patched, compiled, tested and it works.
And I've just tested it again.
Here is the sequence of commands (careful, it deletes WINEPREFIX):
export WINEPREFIX=/home/gugamilare/.wine-test/
rm -rf dlls/winedib.drv/
git checkout -f
make clean
git reset --hard f2b993d414517037cf064e9aed954cdae96646f5
sh patches/series # I transformed the file "series" of the tarball into a
script
autoconf
CC="ccache gcc" ./configure && make depend && make
rm -rf $WINEPREFIX
./wine notepad # => works
rm -rf $WINEPREFIX
WINEDIB=ON ./wine notepad # => crashes
rm -rf dlls/winedib.drv/
git checkout -f
make clean
git reset --hard 5532927ed33f3682c48bdc2a2528488eeefa5bad
sh patches/series
autoconf
CC="ccache gcc" ./configure && make depend && make
rm -rf $WINEPREFIX
WINEDIB=ON ./wine notepad # => works
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=6682
Nikolay Sivov <bunglehead(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|comctl32 |-unknown
Severity|normal |trivial
--- Comment #20 from Nikolay Sivov <bunglehead(a)gmail.com> 2010-05-25 15:39:16 ---
(In reply to comment #14)
> 1) The image shows up as soon as you start moving this window (i.e. after it
> has been refreshed at least once) - both in Wine and Crossover, unfortunately
> it doesn't get properly repainted when being crossed with other applications'
> windows.
>
This is still an issue with current Wine but native comctl32 doesn't help at
all. Resetting component.
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=6682
Nikolay Sivov <bunglehead(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
URL|http://appdb.winehq.org/app |http://www.irfanview.com/
|view.php?iVersionId=4594 |
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9030
Boran Car <boran.car(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #28194|0 |1
is obsolete| |
Attachment #28195|0 |1
is obsolete| |
--- Comment #26 from Boran Car <boran.car(a)gmail.com> 2010-05-25 15:19:12 ---
Created an attachment (id=28283)
--> (http://bugs.winehq.org/attachment.cgi?id=28283)
Legal screen
Using my custom hacked palette in X11Drv_CopyDIBSection
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=6095
Boran Car <boran.car(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |boran.car(a)gmail.com
--- Comment #59 from Boran Car <boran.car(a)gmail.com> 2010-05-25 15:18:19 ---
Sorry, the upper two screenshots go to ArmyMen, I don't know how they got here
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.
http://bugs.winehq.org/show_bug.cgi?id=9030
--- Comment #25 from Boran Car <boran.car(a)gmail.com> 2010-05-25 15:13:44 ---
Just to report my investigation results here. I have debugged the application
using GDB. I have also added my custom palette in X11DRV_DIB_CopyDIBSection by
taking the square root of the index of the entry module 256. Without this hack,
I was not able to obtain the picture.
I have noticed while debugging that no data gets written to the surface address
between Lock and Unlock which is confusing. Second, there was no indication of
using memcpy or memmove in between (a by hand method is needed, I have
implemented a custom method in surface.c to call from GDB, since memcpy also
didn't work when called from GDB).
As you can see, the bitmap is written bottom-up. Any clues? Is there a method
that copies data inverted?
--
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.