winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
July
June
May
April
March
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
November 2011
----- 2025 -----
July 2025
June 2025
May 2025
April 2025
March 2025
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
852 discussions
Start a n
N
ew thread
Piotr Caban : msvcp90: Reorganize __ASM_EXCEPTION_VTABLE macro.
by Alexandre Julliard
25 Nov '11
25 Nov '11
Module: wine Branch: master Commit: 1c04cbfd336cc8867162468c8027f31492938a0f URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1c04cbfd336cc8867162468c8…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Nov 25 10:46:30 2011 +0100 msvcp90: Reorganize __ASM_EXCEPTION_VTABLE macro. --- dlls/msvcp90/exception.c | 26 +++++++++----------------- 1 files changed, 9 insertions(+), 17 deletions(-) diff --git a/dlls/msvcp90/exception.c b/dlls/msvcp90/exception.c index 00fb0f0..77e1e60 100644 --- a/dlls/msvcp90/exception.c +++ b/dlls/msvcp90/exception.c @@ -64,20 +64,12 @@ void WINAPI _CxxThrowException(exception*,const cxx_exception_type*); #ifdef _WIN64 -#define __ASM_EXCEPTION_VTABLE(name) \ - __ASM_VTABLE(name, "\t.quad " THISCALL_NAME(MSVCP_what_exception) ) - -#define __ASM_EXCEPTION_STRING_VTABLE(name) \ - __ASM_VTABLE(name, "\t.quad " THISCALL_NAME(MSVCP_logic_error_what) ) - +#define __ASM_EXCEPTION_VTABLE(name, what_func) \ + __ASM_VTABLE(name, "\t.quad " THISCALL_NAME(what_func) ) #else -#define __ASM_EXCEPTION_VTABLE(name) \ - __ASM_VTABLE(name, "\t.long " THISCALL_NAME(MSVCP_what_exception) ) - -#define __ASM_EXCEPTION_STRING_VTABLE(name) \ - __ASM_VTABLE(name, "\t.long " THISCALL_NAME(MSVCP_logic_error_what) ) - +#define __ASM_EXCEPTION_VTABLE(name, what_func) \ + __ASM_VTABLE(name, "\t.long " THISCALL_NAME(what_func) ) #endif /* _WIN64 */ extern const vtable_ptr MSVCP_bad_alloc_vtable; @@ -688,11 +680,11 @@ static const cxx_exception_type invalid_argument_cxx_type = { #ifndef __GNUC__ void __asm_dummy_vtables(void) { #endif - __ASM_EXCEPTION_VTABLE(bad_alloc); - __ASM_EXCEPTION_STRING_VTABLE(logic_error); - __ASM_EXCEPTION_STRING_VTABLE(length_error); - __ASM_EXCEPTION_STRING_VTABLE(out_of_range); - __ASM_EXCEPTION_STRING_VTABLE(invalid_argument); + __ASM_EXCEPTION_VTABLE(bad_alloc, MSVCP_what_exception); + __ASM_EXCEPTION_VTABLE(logic_error, MSVCP_logic_error_what); + __ASM_EXCEPTION_VTABLE(length_error, MSVCP_logic_error_what); + __ASM_EXCEPTION_VTABLE(out_of_range, MSVCP_logic_error_what); + __ASM_EXCEPTION_VTABLE(invalid_argument, MSVCP_logic_error_what); #ifndef __GNUC__ } #endif
1
0
0
0
Piotr Caban : msvcp90: Added _Timevec class implementation.
by Alexandre Julliard
25 Nov '11
25 Nov '11
Module: wine Branch: master Commit: 913b075b079fd117d533a6e197a2c8b58ab37148 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=913b075b079fd117d533a6e19…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Nov 25 10:46:18 2011 +0100 msvcp90: Added _Timevec class implementation. --- dlls/msvcp90/locale.c | 32 ++++++++++++++++++++------------ 1 files changed, 20 insertions(+), 12 deletions(-) diff --git a/dlls/msvcp90/locale.c b/dlls/msvcp90/locale.c index 29069e7..e928d3e 100644 --- a/dlls/msvcp90/locale.c +++ b/dlls/msvcp90/locale.c @@ -653,11 +653,14 @@ basic_string_char __thiscall locale_name(const locale *this) /* ??0_Timevec@std@@QAE@ABV01@@Z */ /* ??0_Timevec@std@@QEAA@AEBV01@@Z */ +/* This copy constructor modifies copied object */ DEFINE_THISCALL_WRAPPER(_Timevec_copy_ctor, 8) -_Timevec* __thiscall _Timevec_copy_ctor(_Timevec *this, const _Timevec *copy) +_Timevec* __thiscall _Timevec_copy_ctor(_Timevec *this, _Timevec *copy) { - FIXME("(%p %p) stub\n", this, copy); - return NULL; + TRACE("(%p %p)\n", this, copy); + this->timeptr = copy->timeptr; + copy->timeptr = NULL; + return this; } /* ??0_Timevec@std@@QAE@PAX@Z */ @@ -665,8 +668,9 @@ _Timevec* __thiscall _Timevec_copy_ctor(_Timevec *this, const _Timevec *copy) DEFINE_THISCALL_WRAPPER(_Timevec_ctor_timeptr, 8) _Timevec* __thiscall _Timevec_ctor_timeptr(_Timevec *this, void *timeptr) { - FIXME("(%p %p) stub\n", this, timeptr); - return NULL; + TRACE("(%p %p)\n", this, timeptr); + this->timeptr = timeptr; + return this; } /* ??_F_Timevec@std@@QAEXXZ */ @@ -674,8 +678,9 @@ _Timevec* __thiscall _Timevec_ctor_timeptr(_Timevec *this, void *timeptr) DEFINE_THISCALL_WRAPPER(_Timevec_ctor, 4) _Timevec* __thiscall _Timevec_ctor(_Timevec *this) { - FIXME("(%p) stub\n", this); - return NULL; + TRACE("(%p)\n", this); + this->timeptr = NULL; + return this; } /* ??1_Timevec@std@@QAE@XZ */ @@ -683,7 +688,8 @@ _Timevec* __thiscall _Timevec_ctor(_Timevec *this) DEFINE_THISCALL_WRAPPER(_Timevec_dtor, 4) void __thiscall _Timevec_dtor(_Timevec *this) { - FIXME("(%p) stub\n", this); + TRACE("(%p)\n", this); + MSVCRT_operator_delete(this->timeptr); } /* ??4_Timevec@std@@QAEAAV01@ABV01@@Z */ @@ -691,8 +697,10 @@ void __thiscall _Timevec_dtor(_Timevec *this) DEFINE_THISCALL_WRAPPER(_Timevec_op_assign, 8) _Timevec* __thiscall _Timevec_op_assign(_Timevec *this, _Timevec *right) { - FIXME("(%p %p) stub\n", this, right); - return NULL; + TRACE("(%p %p)\n", this, right); + this->timeptr = right->timeptr; + right->timeptr = NULL; + return this; } /* ?_Getptr@_Timevec@std@@QBEPAXXZ */ @@ -700,8 +708,8 @@ _Timevec* __thiscall _Timevec_op_assign(_Timevec *this, _Timevec *right) DEFINE_THISCALL_WRAPPER(_Timevec__Getptr, 4) void* __thiscall _Timevec__Getptr(_Timevec *this) { - FIXME("(%p) stub\n", this); - return NULL; + TRACE("(%p)\n", this); + return this->timeptr; } /* ?_Locinfo_ctor@_Locinfo@std@@SAXPAV12@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@2@@Z */
1
0
0
0
Piotr Caban : msvcp90: Added locale::name implementation.
by Alexandre Julliard
25 Nov '11
25 Nov '11
Module: wine Branch: master Commit: e10dcd0c328d7ed26e6d38f25bb87f9603938ccc URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e10dcd0c328d7ed26e6d38f25…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Nov 25 10:46:06 2011 +0100 msvcp90: Added locale::name implementation. --- dlls/msvcp90/locale.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/dlls/msvcp90/locale.c b/dlls/msvcp90/locale.c index f985136..29069e7 100644 --- a/dlls/msvcp90/locale.c +++ b/dlls/msvcp90/locale.c @@ -647,9 +647,8 @@ const locale* __cdecl locale_classic(void) DEFINE_THISCALL_WRAPPER_RETPTR(locale_name, 4) basic_string_char __thiscall locale_name(const locale *this) { - basic_string_char ret = { 0 }; /* FIXME */ - FIXME( "(%p) stub\n", this); - return ret; + TRACE( "(%p)\n", this); + return this->ptr->name; } /* ??0_Timevec@std@@QAE@ABV01@@Z */
1
0
0
0
Piotr Caban : msvcp90: Added locale::_Addfac implementation.
by Alexandre Julliard
25 Nov '11
25 Nov '11
Module: wine Branch: master Commit: 2e449eba0851bef828039dd129bbeb1ca2deae36 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2e449eba0851bef828039dd12…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Nov 25 10:45:55 2011 +0100 msvcp90: Added locale::_Addfac implementation. --- dlls/msvcp90/locale.c | 23 +++++++++++++++++++++-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/dlls/msvcp90/locale.c b/dlls/msvcp90/locale.c index 61a3353..f985136 100644 --- a/dlls/msvcp90/locale.c +++ b/dlls/msvcp90/locale.c @@ -579,8 +579,27 @@ MSVCP_bool __thiscall locale_operator_not_equal(const locale *this, locale const DEFINE_THISCALL_WRAPPER(locale__Addfac, 16) locale* __thiscall locale__Addfac(locale *this, locale_facet *facet, MSVCP_size_t id, MSVCP_size_t catmask) { - FIXME("(%p %p %lu %lu) stub\n", this, facet, id, catmask); - return NULL; + TRACE("(%p %p %lu %lu)\n", this, facet, id, catmask); + + if(this->ptr->facet.refs > 1) { + locale__Locimp *new_ptr = MSVCRT_operator_new(sizeof(locale__Locimp)); + if(!new_ptr) { + ERR("Out of memory\n"); + throw_exception(EXCEPTION_BAD_ALLOC, NULL); + return NULL; + } + locale__Locimp_copy_ctor(new_ptr, this->ptr); + locale_facet__Decref(&this->ptr->facet); + this->ptr = new_ptr; + } + + locale__Locimp__Addfac(this->ptr, facet, id); + + if(catmask) { + MSVCP_basic_string_char_dtor(&this->ptr->name); + MSVCP_basic_string_char_ctor_cstr(&this->ptr->name, "*"); + } + return this; } /* ?_Getfacet@locale@std@@QBEPBVfacet@12@I@Z */
1
0
0
0
Piotr Caban : msvcp90: Added locale copy based constructors implementation.
by Alexandre Julliard
25 Nov '11
25 Nov '11
Module: wine Branch: master Commit: 1263b618d7945e817b70a85560c69850e5a881e8 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1263b618d7945e817b70a8556…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Nov 25 10:45:41 2011 +0100 msvcp90: Added locale copy based constructors implementation. --- dlls/msvcp90/locale.c | 29 ++++++++++++++++++++++------- 1 files changed, 22 insertions(+), 7 deletions(-) diff --git a/dlls/msvcp90/locale.c b/dlls/msvcp90/locale.c index f05cc79..61a3353 100644 --- a/dlls/msvcp90/locale.c +++ b/dlls/msvcp90/locale.c @@ -274,15 +274,18 @@ locale__Locimp* __thiscall locale__Locimp_ctor(locale__Locimp *this) DEFINE_THISCALL_WRAPPER(locale__Locimp_copy_ctor, 8) locale__Locimp* __thiscall locale__Locimp_copy_ctor(locale__Locimp *this, const locale__Locimp *copy) { + _Lockit lock; MSVCP_size_t i; TRACE("(%p %p)\n", this, copy); + _Lockit_ctor_locktype(&lock, _LOCK_LOCALE); memcpy(this, copy, sizeof(locale__Locimp)); locale_facet_ctor_refs(&this->facet, 1); if(copy->facetvec) { this->facetvec = MSVCRT_operator_new(copy->facet_cnt*sizeof(locale_facet*)); if(!this->facetvec) { + _Lockit_dtor(&lock); ERR("Out of memory\n"); throw_exception(EXCEPTION_BAD_ALLOC, NULL); return NULL; @@ -292,6 +295,7 @@ locale__Locimp* __thiscall locale__Locimp_copy_ctor(locale__Locimp *this, const locale_facet__Incref(this->facetvec[i]); } MSVCP_basic_string_char_copy_ctor(&this->name, ©->name); + _Lockit_dtor(&lock); return this; } @@ -351,8 +355,11 @@ locale__Locimp* __thiscall MSVCP_locale__Locimp_vector_dtor(locale__Locimp *this /* ?_Locimp_Addfac@_Locimp@locale@std@@CAXPEAV123@PEAVfacet@23@_K@Z */ void __cdecl locale__Locimp__Locimp_Addfac(locale__Locimp *locimp, locale_facet *facet, MSVCP_size_t id) { + _Lockit lock; + TRACE("(%p %p %lu)\n", locimp, facet, id); + _Lockit_ctor_locktype(&lock, _LOCK_LOCALE); if(id >= locimp->facet_cnt) { MSVCP_size_t new_size = id+1; locale_facet **new_facetvec; @@ -362,6 +369,7 @@ void __cdecl locale__Locimp__Locimp_Addfac(locale__Locimp *locimp, locale_facet new_facetvec = MSVCRT_operator_new(sizeof(locale_facet*)*new_size); if(!new_facetvec) { + _Lockit_dtor(&lock); ERR("Out of memory\n"); throw_exception(EXCEPTION_BAD_ALLOC, NULL); return; @@ -380,6 +388,7 @@ void __cdecl locale__Locimp__Locimp_Addfac(locale__Locimp *locimp, locale_facet locimp->facetvec[id] = facet; if(facet) locale_facet__Incref(facet); + _Lockit_dtor(&lock); } /* ?_Addfac@_Locimp@locale@std@@AAEXPAVfacet@23@I@Z */ @@ -437,8 +446,10 @@ const vtable_ptr MSVCP_locale__Locimp_vtable[] = { DEFINE_THISCALL_WRAPPER(locale_ctor_locimp, 8) locale* __thiscall locale_ctor_locimp(locale *this, locale__Locimp *locimp) { - FIXME("(%p %p) stub\n", this, locimp); - return NULL; + TRACE("(%p %p)\n", this, locimp); + /* Don't change locimp reference counter */ + this->ptr = locimp; + return this; } /* ??0locale@std@@QAE@ABV01@0H@Z */ @@ -455,8 +466,10 @@ locale* __thiscall locale_ctor_locale_locale(locale *this, const locale *loc, co DEFINE_THISCALL_WRAPPER(locale_copy_ctor, 8) locale* __thiscall locale_copy_ctor(locale *this, const locale *copy) { - FIXME("(%p %p) stub\n", this, copy); - return NULL; + TRACE("(%p %p)\n", this, copy); + this->ptr = copy->ptr; + locale_facet__Incref(&this->ptr->facet); + return this; } /* ??0locale@std@@QAE@ABV01@PBDH@Z */ @@ -482,8 +495,9 @@ locale* __thiscall locale_ctor_cstr(locale *this, const char *locname, category DEFINE_THISCALL_WRAPPER(locale_ctor_uninitialized, 8) locale* __thiscall locale_ctor_uninitialized(locale *this, int uninitialized) { - FIXME("(%p %d) stub\n", this, uninitialized); - return NULL; + TRACE("(%p)\n", this); + this->ptr = NULL; + return this; } /* ??0locale@std@@QAE@XZ */ @@ -509,7 +523,8 @@ DEFINE_THISCALL_WRAPPER(locale_dtor, 4) void __thiscall locale_dtor(locale *this) { TRACE("(%p)\n", this); - locale__Locimp_dtor(this->ptr); + if(this->ptr) + locale__Locimp_dtor(this->ptr); } DEFINE_THISCALL_WRAPPER(MSVCP_locale_vector_dtor, 8)
1
0
0
0
Henri Verbeet : wined3d: Get rid of the WINED3DVERTEXELEMENT typedef.
by Alexandre Julliard
25 Nov '11
25 Nov '11
Module: wine Branch: master Commit: 6a529e58471deb15be72eb248c8a69dfcde78419 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6a529e58471deb15be72eb248…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Nov 24 22:52:36 2011 +0100 wined3d: Get rid of the WINED3DVERTEXELEMENT typedef. --- dlls/d3d10core/inputlayout.c | 6 +++--- dlls/d3d8/vertexdeclaration.c | 8 ++++---- dlls/d3d9/vertexdeclaration.c | 8 ++++---- dlls/wined3d/vertexdeclaration.c | 19 ++++++++++--------- include/wine/wined3d.h | 6 +++--- 5 files changed, 24 insertions(+), 23 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=6a529e58471deb15be72e…
1
0
0
0
Henri Verbeet : wined3d: Get rid of the WINED3DCLIPSTATUS typedef.
by Alexandre Julliard
25 Nov '11
25 Nov '11
Module: wine Branch: master Commit: 1c74172a28586e408d6224638cc1311f28f9238f URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1c74172a28586e408d6224638…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Nov 24 22:52:35 2011 +0100 wined3d: Get rid of the WINED3DCLIPSTATUS typedef. --- dlls/d3d8/device.c | 6 +++--- dlls/d3d9/device.c | 4 ++-- dlls/wined3d/device.c | 6 ++++-- include/wine/wined3d.h | 14 ++++++++------ 4 files changed, 17 insertions(+), 13 deletions(-) diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c index eb398ab..c003993 100644 --- a/dlls/d3d8/device.c +++ b/dlls/d3d8/device.c @@ -1648,10 +1648,10 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetClipStatus(IDirect3DDevice8 *iface HRESULT hr; TRACE("iface %p, clip_status %p.\n", iface, pClipStatus); -/* FIXME: Verify that D3DCLIPSTATUS8 ~= WINED3DCLIPSTATUS */ + /* FIXME: Verify that D3DCLIPSTATUS8 ~= struct wined3d_clip_status. */ wined3d_mutex_lock(); - hr = wined3d_device_set_clip_status(This->wined3d_device, (const WINED3DCLIPSTATUS *)pClipStatus); + hr = wined3d_device_set_clip_status(This->wined3d_device, (const struct wined3d_clip_status *)pClipStatus); wined3d_mutex_unlock(); return hr; @@ -1666,7 +1666,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_GetClipStatus(IDirect3DDevice8 *iface TRACE("iface %p, clip_status %p.\n", iface, pClipStatus); wined3d_mutex_lock(); - hr = wined3d_device_get_clip_status(This->wined3d_device, (WINED3DCLIPSTATUS *)pClipStatus); + hr = wined3d_device_get_clip_status(This->wined3d_device, (struct wined3d_clip_status *)pClipStatus); wined3d_mutex_unlock(); return hr; diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c index 32215c5..49a3215 100644 --- a/dlls/d3d9/device.c +++ b/dlls/d3d9/device.c @@ -1580,7 +1580,7 @@ static HRESULT WINAPI IDirect3DDevice9Impl_SetClipStatus(IDirect3DDevice9Ex *ifa TRACE("iface %p, clip_status %p.\n", iface, pClipStatus); wined3d_mutex_lock(); - hr = wined3d_device_set_clip_status(This->wined3d_device, (const WINED3DCLIPSTATUS *)pClipStatus); + hr = wined3d_device_set_clip_status(This->wined3d_device, (const struct wined3d_clip_status *)pClipStatus); wined3d_mutex_unlock(); return hr; @@ -1595,7 +1595,7 @@ static HRESULT WINAPI IDirect3DDevice9Impl_GetClipStatus(IDirect3DDevice9Ex *ifa TRACE("iface %p, clip_status %p.\n", iface, pClipStatus); wined3d_mutex_lock(); - hr = wined3d_device_get_clip_status(This->wined3d_device, (WINED3DCLIPSTATUS *)pClipStatus); + hr = wined3d_device_get_clip_status(This->wined3d_device, (struct wined3d_clip_status *)pClipStatus); wined3d_mutex_unlock(); return hr; diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index e12f48a..6e35c0a 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -2260,7 +2260,8 @@ HRESULT CDECL wined3d_device_get_clip_plane(const struct wined3d_device *device, return WINED3D_OK; } -HRESULT CDECL wined3d_device_set_clip_status(struct wined3d_device *device, const WINED3DCLIPSTATUS *clip_status) +HRESULT CDECL wined3d_device_set_clip_status(struct wined3d_device *device, + const struct wined3d_clip_status *clip_status) { FIXME("device %p, clip_status %p stub!\n", device, clip_status); @@ -2270,7 +2271,8 @@ HRESULT CDECL wined3d_device_set_clip_status(struct wined3d_device *device, cons return WINED3D_OK; } -HRESULT CDECL wined3d_device_get_clip_status(const struct wined3d_device *device, WINED3DCLIPSTATUS *clip_status) +HRESULT CDECL wined3d_device_get_clip_status(const struct wined3d_device *device, + struct wined3d_clip_status *clip_status) { FIXME("device %p, clip_status %p stub!\n", device, clip_status); diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h index 5bcc35b..a68e0d3 100644 --- a/include/wine/wined3d.h +++ b/include/wine/wined3d.h @@ -1667,11 +1667,11 @@ struct wined3d_resource_desc UINT size; }; -typedef struct _WINED3DCLIPSTATUS +struct wined3d_clip_status { - DWORD ClipUnion; - DWORD ClipIntersection; -} WINED3DCLIPSTATUS; + DWORD clip_union; + DWORD clip_intersection; +}; typedef struct _WINED3DVERTEXELEMENT { @@ -2200,7 +2200,8 @@ HRESULT __cdecl wined3d_device_get_back_buffer(const struct wined3d_device *devi UINT backbuffer_idx, WINED3DBACKBUFFER_TYPE backbuffer_type, struct wined3d_surface **backbuffer); INT __cdecl wined3d_device_get_base_vertex_index(const struct wined3d_device *device); HRESULT __cdecl wined3d_device_get_clip_plane(const struct wined3d_device *device, UINT plane_idx, float *plane); -HRESULT __cdecl wined3d_device_get_clip_status(const struct wined3d_device *device, WINED3DCLIPSTATUS *clip_status); +HRESULT __cdecl wined3d_device_get_clip_status(const struct wined3d_device *device, + struct wined3d_clip_status *clip_status); HRESULT __cdecl wined3d_device_get_creation_parameters(const struct wined3d_device *device, WINED3DDEVICE_CREATION_PARAMETERS *creation_parameters); HRESULT __cdecl wined3d_device_get_depth_stencil(const struct wined3d_device *device, @@ -2280,7 +2281,8 @@ HRESULT __cdecl wined3d_device_reset(struct wined3d_device *device, void __cdecl wined3d_device_restore_fullscreen_window(struct wined3d_device *device, HWND window); HRESULT __cdecl wined3d_device_set_base_vertex_index(struct wined3d_device *device, INT base_index); HRESULT __cdecl wined3d_device_set_clip_plane(struct wined3d_device *device, UINT plane_idx, const float *plane); -HRESULT __cdecl wined3d_device_set_clip_status(struct wined3d_device *device, const WINED3DCLIPSTATUS *clip_status); +HRESULT __cdecl wined3d_device_set_clip_status(struct wined3d_device *device, + const struct wined3d_clip_status *clip_status); void __cdecl wined3d_device_set_cursor_position(struct wined3d_device *device, int x_screen_space, int y_screen_space, DWORD flags); HRESULT __cdecl wined3d_device_set_cursor_properties(struct wined3d_device *device,
1
0
0
0
Henri Verbeet : wined3d: Handle changing the backbuffer format in wined3d_device_reset().
by Alexandre Julliard
25 Nov '11
25 Nov '11
Module: wine Branch: master Commit: 094f64c823ed65629ebbec78a4b1f5e4583c0142 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=094f64c823ed65629ebbec78a…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Nov 24 22:52:34 2011 +0100 wined3d: Handle changing the backbuffer format in wined3d_device_reset(). --- dlls/wined3d/device.c | 13 +++++++++---- 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index d165806..e12f48a 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -5241,6 +5241,8 @@ static HRESULT updateSurfaceDesc(struct wined3d_surface *surface, while (surface->pow2Height < pPresentationParameters->BackBufferHeight) surface->pow2Height <<= 1; } + if (!(surface->resource.usage & WINED3DUSAGE_DEPTHSTENCIL)) + surface->resource.format = wined3d_get_format(gl_info, pPresentationParameters->BackBufferFormat); surface->resource.multisample_type = pPresentationParameters->MultiSampleType; surface->resource.multisample_quality = pPresentationParameters->MultiSampleQuality; @@ -5498,10 +5500,6 @@ HRESULT CDECL wined3d_device_reset(struct wined3d_device *device, && present_parameters->BackBufferCount != swapchain->presentParms.BackBufferCount) FIXME("Cannot change the back buffer count yet.\n"); - if (present_parameters->BackBufferFormat != WINED3DFMT_UNKNOWN - && present_parameters->BackBufferFormat != swapchain->presentParms.BackBufferFormat) - FIXME("Cannot change the back buffer format yet.\n"); - if (present_parameters->hDeviceWindow && present_parameters->hDeviceWindow != swapchain->presentParms.hDeviceWindow) FIXME("Cannot change the device window yet.\n"); @@ -5572,6 +5570,13 @@ HRESULT CDECL wined3d_device_reset(struct wined3d_device *device, update_desc = TRUE; } + if (present_parameters->BackBufferFormat != WINED3DFMT_UNKNOWN + && present_parameters->BackBufferFormat != swapchain->presentParms.BackBufferFormat) + { + swapchain->presentParms.BackBufferFormat = present_parameters->BackBufferFormat; + update_desc = TRUE; + } + if (present_parameters->MultiSampleType != swapchain->presentParms.MultiSampleType || present_parameters->MultiSampleQuality != swapchain->presentParms.MultiSampleQuality) {
1
0
0
0
Henri Verbeet : wined3d: Use the correct backbuffer format in wined3d_device_reset().
by Alexandre Julliard
25 Nov '11
25 Nov '11
Module: wine Branch: master Commit: f51bf61d2fa3fc1ba6a9f9da9a365a9c7415b850 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f51bf61d2fa3fc1ba6a9f9da9…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Nov 24 22:52:33 2011 +0100 wined3d: Use the correct backbuffer format in wined3d_device_reset(). --- dlls/wined3d/device.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 3737abb..d165806 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -5556,7 +5556,7 @@ HRESULT CDECL wined3d_device_reset(struct wined3d_device *device, mode.width = present_parameters->BackBufferWidth; mode.height = present_parameters->BackBufferHeight; mode.refresh_rate = present_parameters->FullScreen_RefreshRateInHz; - mode.format_id = swapchain->presentParms.BackBufferFormat; + mode.format_id = present_parameters->BackBufferFormat; } /* Should Width == 800 && Height == 0 set 800x600? */
1
0
0
0
Henri Verbeet : wined3d: Don't apply fixups to converted surfaces.
by Alexandre Julliard
25 Nov '11
25 Nov '11
Module: wine Branch: master Commit: 24775459c8892b8e92f42ac9a66946f50b0b1190 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=24775459c8892b8e92f42ac9a…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Nov 24 22:52:32 2011 +0100 wined3d: Don't apply fixups to converted surfaces. --- dlls/wined3d/arb_program_shader.c | 9 +++++++++ dlls/wined3d/surface.c | 3 ++- 2 files changed, 11 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index 451d34a..b2fa29c 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -7137,6 +7137,15 @@ static HRESULT arbfp_blit_set(void *blit_priv, struct wined3d_context *context, GLenum textype = surface->texture_target; const struct wined3d_gl_info *gl_info = context->gl_info; + if (surface->flags & SFLAG_CONVERTED) + { + ENTER_GL(); + glEnable(textype); + checkGLcall("glEnable(textype)"); + LEAVE_GL(); + return WINED3D_OK; + } + if (!is_complex_fixup(surface->resource.format->color_fixup)) { TRACE("Fixup:\n"); diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index 865f83e..4c9cc84 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -6229,7 +6229,8 @@ static HRESULT ffp_blit_set(void *blit_priv, struct wined3d_context *context, co /* When EXT_PALETTED_TEXTURE is around, palette conversion is done by the GPU * else the surface is converted in software at upload time in LoadLocation. */ - if(fixup == COMPLEX_FIXUP_P8 && context->gl_info->supported[EXT_PALETTED_TEXTURE]) + if (!(surface->flags & SFLAG_CONVERTED) && fixup == COMPLEX_FIXUP_P8 + && context->gl_info->supported[EXT_PALETTED_TEXTURE]) ffp_blit_p8_upload_palette(surface, context->gl_info); ENTER_GL();
1
0
0
0
← Newer
1
...
11
12
13
14
15
16
17
...
86
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
Results per page:
10
25
50
100
200