winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
July
June
May
April
March
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
November 2011
----- 2025 -----
July 2025
June 2025
May 2025
April 2025
March 2025
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
852 discussions
Start a n
N
ew thread
Jacek Caban : mshtml: Properly remove event listeners.
by Alexandre Julliard
24 Nov '11
24 Nov '11
Module: wine Branch: master Commit: ea0ebbfeb2c513e41d0ebf1812ff3f40bd728dbd URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ea0ebbfeb2c513e41d0ebf181…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Nov 24 12:48:31 2011 +0100 mshtml: Properly remove event listeners. --- dlls/mshtml/htmldoc.c | 1 + dlls/mshtml/htmlevent.c | 14 ++++++++++++++ dlls/mshtml/htmlevent.h | 2 ++ dlls/mshtml/htmlwindow.c | 1 + dlls/mshtml/nsevents.c | 30 +++++++++++++++++++++++++++++- 5 files changed, 47 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/htmldoc.c b/dlls/mshtml/htmldoc.c index 32cbde4..45a7986 100644 --- a/dlls/mshtml/htmldoc.c +++ b/dlls/mshtml/htmldoc.c @@ -2032,6 +2032,7 @@ static void HTMLDocumentNode_destructor(HTMLDOMNode *iface) heap_free(This->elem_vars[i]); heap_free(This->elem_vars); + detach_events(This); if(This->body_event_target) release_event_target(This->body_event_target); if(This->nsevent_listener) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index 2b9e62e..74e8069 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -1184,6 +1184,20 @@ static HRESULT ensure_nsevent_handler(HTMLDocumentNode *doc, event_target_t *eve return S_OK; } +void detach_events(HTMLDocumentNode *doc) +{ + int i; + + if(!doc->event_vector) + return; + + for(i=0; i < EVENTID_LAST; i++) { + if(doc->event_vector[i]) + detach_nsevent(doc, event_info[i].name); + } +} + + static HRESULT remove_event_handler(event_target_t **event_target, eventid_t eid) { if(*event_target && (*event_target)->event_table[eid] && (*event_target)->event_table[eid]->handler_prop) { diff --git a/dlls/mshtml/htmlevent.h b/dlls/mshtml/htmlevent.h index 9072482..b3ff251 100644 --- a/dlls/mshtml/htmlevent.h +++ b/dlls/mshtml/htmlevent.h @@ -54,10 +54,12 @@ HRESULT dispatch_event(HTMLDOMNode*,const WCHAR*,VARIANT*,VARIANT_BOOL*) DECLSPE HRESULT call_fire_event(HTMLDOMNode*,eventid_t) DECLSPEC_HIDDEN; void update_cp_events(HTMLWindow*,event_target_t**,cp_static_data_t*,nsIDOMNode*) DECLSPEC_HIDDEN; HRESULT doc_init_events(HTMLDocumentNode*) DECLSPEC_HIDDEN; +void detach_events(HTMLDocumentNode *doc) DECLSPEC_HIDDEN; void init_nsevents(HTMLDocumentNode*) DECLSPEC_HIDDEN; void release_nsevents(HTMLDocumentNode*) DECLSPEC_HIDDEN; void add_nsevent_listener(HTMLDocumentNode*,nsIDOMNode*,LPCWSTR) DECLSPEC_HIDDEN; +void detach_nsevent(HTMLDocumentNode*,const WCHAR*) DECLSPEC_HIDDEN; static inline event_target_t **get_node_event_target(HTMLDOMNode *node) { diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index e9bb8eb..f907776 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -46,6 +46,7 @@ static void window_set_docnode(HTMLWindow *window, HTMLDocumentNode *doc_node) if(window->doc) { if(window->doc_obj && window == window->doc_obj->basedoc.window) window->doc->basedoc.cp_container.forward_container = NULL; + detach_events(window->doc); abort_document_bindings(window->doc); window->doc->basedoc.window = NULL; htmldoc_release(&window->doc->basedoc); diff --git a/dlls/mshtml/nsevents.c b/dlls/mshtml/nsevents.c index 89684fe..d4cdc10 100644 --- a/dlls/mshtml/nsevents.c +++ b/dlls/mshtml/nsevents.c @@ -281,7 +281,7 @@ static nsresult NSAPI handle_htmlevent(nsIDOMEventListener *iface, nsIDOMEvent * eventid_t eid; nsresult nsres; - TRACE("\n"); + TRACE("%p\n", This->This); nsAString_Init(&type_str, NULL); nsIDOMEvent_GetType(event, &type_str); @@ -363,8 +363,34 @@ void add_nsevent_listener(HTMLDocumentNode *doc, nsIDOMNode *nsnode, LPCWSTR typ nsIDOMEventTarget_Release(target); } +void detach_nsevent(HTMLDocumentNode *doc, const WCHAR *type) +{ + nsIDOMEventTarget *target; + nsAString type_str; + nsresult nsres; + + if(!doc->basedoc.window) + return; + + nsres = nsIDOMWindow_QueryInterface(doc->basedoc.window->nswindow, &IID_nsIDOMEventTarget, (void**)&target); + if(NS_FAILED(nsres)) { + ERR("Could not get nsIDOMEventTarget interface: %08x\n", nsres); + return; + } + + nsAString_InitDepend(&type_str, type); + nsres = nsIDOMEventTarget_RemoveEventListener(target, &type_str, + &doc->nsevent_listener->htmlevent_listener.nsIDOMEventListener_iface, TRUE); + nsAString_Finish(&type_str); + nsIDOMEventTarget_Release(target); + if(NS_FAILED(nsres)) + ERR("RemoveEventTarget failed: %08x\n", nsres); +} + void release_nsevents(HTMLDocumentNode *doc) { + TRACE("%p %p\n", doc, doc->nsevent_listener); + if(doc->nsevent_listener) { doc->nsevent_listener->doc = NULL; release_listener(doc->nsevent_listener); @@ -387,6 +413,8 @@ void init_nsevents(HTMLDocumentNode *doc) if(!listener) return; + TRACE("%p %p\n", doc, listener); + listener->ref = 1; listener->doc = doc;
1
0
0
0
Piotr Caban : msvcrt: Fix FILE critical section initialization.
by Alexandre Julliard
24 Nov '11
24 Nov '11
Module: wine Branch: master Commit: 66520ea08a5960bc15312dae71190969de478d66 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=66520ea08a5960bc15312dae7…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu Nov 24 12:13:03 2011 +0100 msvcrt: Fix FILE critical section initialization. --- dlls/msvcrt/file.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c index 7a034d3..c4ba546 100644 --- a/dlls/msvcrt/file.c +++ b/dlls/msvcrt/file.c @@ -364,8 +364,11 @@ static MSVCRT_FILE* msvcrt_alloc_fp(void) { if (i == MSVCRT_stream_idx) { - InitializeCriticalSection(&((file_crit*)file)->crit); - ((file_crit*)file)->crit.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": file_crit.crit"); + if (file<MSVCRT__iob || file>=MSVCRT__iob+_IOB_ENTRIES) + { + InitializeCriticalSection(&((file_crit*)file)->crit); + ((file_crit*)file)->crit.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": file_crit.crit"); + } MSVCRT_stream_idx++; } return file;
1
0
0
0
Frédéric Delanoy : cmd: Avoid dead assignment ( clang).
by Alexandre Julliard
24 Nov '11
24 Nov '11
Module: wine Branch: master Commit: 3d028ab67c6e3f53009bc57513e34a68d834f835 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3d028ab67c6e3f53009bc5751…
Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Thu Nov 24 12:02:40 2011 +0100 cmd: Avoid dead assignment (clang). --- programs/cmd/builtins.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c index 56961a3..6703cef 100644 --- a/programs/cmd/builtins.c +++ b/programs/cmd/builtins.c @@ -517,7 +517,6 @@ void WCMD_copy (void) { } while (FindNextFileW(hff, &fd) != 0); FindClose (hff); } else { - status = ERROR_FILE_NOT_FOUND; WCMD_print_error (); } }
1
0
0
0
Hans Leidekker : ws2_32: Pass NULL nodename on to native getaddrinfo.
by Alexandre Julliard
24 Nov '11
24 Nov '11
Module: wine Branch: master Commit: 8e5d5bf58aa4ad9ac638f0b6e6473b4b8e2dbe83 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=8e5d5bf58aa4ad9ac638f0b6e…
Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Nov 24 11:31:35 2011 +0100 ws2_32: Pass NULL nodename on to native getaddrinfo. --- dlls/ws2_32/socket.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index 72e2a5f..cf33400 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -4824,14 +4824,15 @@ int WINAPI WS_getaddrinfo(LPCSTR nodename, LPCSTR servname, const struct WS_addr if (!nodename && !servname) return WSAHOST_NOT_FOUND; if (!nodename) - node = "localhost"; + node = NULL; else if (!nodename[0]) + { node = hostname = get_hostname(); + if (!node) return WSA_NOT_ENOUGH_MEMORY; + } else node = nodename; - if (!node) return WSA_NOT_ENOUGH_MEMORY; - if (hints) { punixhints = &unixhints;
1
0
0
0
Marcus Meissner : winhttp: Check return value of CLSIDFromProgID (Coverity) .
by Alexandre Julliard
24 Nov '11
24 Nov '11
Module: wine Branch: master Commit: ad5340f63a2e313265308cbc01abd8d10d0536d4 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ad5340f63a2e313265308cbc0…
Author: Marcus Meissner <meissner(a)suse.de> Date: Thu Nov 24 03:04:27 2011 +0100 winhttp: Check return value of CLSIDFromProgID (Coverity). --- dlls/winhttp/session.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/dlls/winhttp/session.c b/dlls/winhttp/session.c index f33508e..110de80 100644 --- a/dlls/winhttp/session.c +++ b/dlls/winhttp/session.c @@ -423,6 +423,7 @@ BOOL set_server_for_hostname( connect_t *connect, LPCWSTR server, INTERNET_PORT session->proxy_server, colon - session->proxy_server - 1 )) { heap_free( connect->servername ); + connect->sockaddr.ss_family = 0xffff; if (!(connect->servername = heap_alloc( (colon - session->proxy_server + 1) * sizeof(WCHAR) ))) { @@ -444,6 +445,7 @@ BOOL set_server_for_hostname( connect_t *connect, LPCWSTR server, INTERNET_PORT session->proxy_server )) { heap_free( connect->servername ); + connect->sockaddr.ss_family = 0xffff; if (!(connect->servername = strdupW( session->proxy_server ))) { ret = FALSE; @@ -456,6 +458,7 @@ BOOL set_server_for_hostname( connect_t *connect, LPCWSTR server, INTERNET_PORT else if (server) { heap_free( connect->servername ); + connect->sockaddr.ss_family = 0xffff; if (!(connect->servername = strdupW( server ))) { ret = FALSE; @@ -1837,7 +1840,9 @@ static BOOL run_script( const BSTR script, const WCHAR *url, WINHTTP_PROXY_INFO hostname[uc.dwHostNameLength] = 0; init = CoInitialize( NULL ); - CLSIDFromProgID( jscriptW, &clsid ); + hr = CLSIDFromProgID( jscriptW, &clsid ); + if (hr != S_OK) goto done; + hr = CoCreateInstance( &clsid, NULL, CLSCTX_INPROC_SERVER|CLSCTX_INPROC_HANDLER, &IID_IActiveScript, (void **)&engine ); if (hr != S_OK) goto done;
1
0
0
0
Marcus Meissner : mshtml: Switch two checks (Coverity).
by Alexandre Julliard
24 Nov '11
24 Nov '11
Module: wine Branch: master Commit: da2089fed4c6bea03997973447d8a469bdd3242d URL:
http://source.winehq.org/git/wine.git/?a=commit;h=da2089fed4c6bea0399797344…
Author: Marcus Meissner <meissner(a)suse.de> Date: Thu Nov 24 02:25:25 2011 +0100 mshtml: Switch two checks (Coverity). --- dlls/mshtml/navigate.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c index 2d8bcd8..9556a00 100644 --- a/dlls/mshtml/navigate.c +++ b/dlls/mshtml/navigate.c @@ -2069,7 +2069,7 @@ HRESULT navigate_url(HTMLWindow *window, const WCHAR *new_url, const WCHAR *base } } - if(window->doc_obj->is_webbrowser && window->doc_obj && window == window->doc_obj->basedoc.window) { + if(window->doc_obj && window->doc_obj->is_webbrowser && window == window->doc_obj->basedoc.window) { BOOL cancel = FALSE; IUri *uri;
1
0
0
0
Marcus Meissner : winhttp: Added missing LeaveCriticalSection (Coverity).
by Alexandre Julliard
24 Nov '11
24 Nov '11
Module: wine Branch: master Commit: e410f3fc663a9932fd1480ef0994b9e81e95f7bf URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e410f3fc663a9932fd1480ef0…
Author: Marcus Meissner <meissner(a)suse.de> Date: Thu Nov 24 02:20:56 2011 +0100 winhttp: Added missing LeaveCriticalSection (Coverity). --- dlls/winhttp/request.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/dlls/winhttp/request.c b/dlls/winhttp/request.c index 257fc97..a56572d 100644 --- a/dlls/winhttp/request.c +++ b/dlls/winhttp/request.c @@ -2973,7 +2973,10 @@ static HRESULT WINAPI winhttp_request_Send( return S_OK; } VariantClear( &request->data ); - if ((hr = VariantCopyInd( &request->data, &body )) != S_OK) return hr; + if ((hr = VariantCopyInd( &request->data, &body )) != S_OK) { + LeaveCriticalSection( &request->cs ); + return hr; + } if (request->wait) /* async request */ {
1
0
0
0
Huw Davies : gdi32: Avoid reading past the end of the indices array.
by Alexandre Julliard
24 Nov '11
24 Nov '11
Module: wine Branch: master Commit: 0ab46cd5e98e4d588e16425d55165e9c4475190b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=0ab46cd5e98e4d588e16425d5…
Author: Huw Davies <huw(a)codeweavers.com> Date: Thu Nov 24 09:26:45 2011 +0000 gdi32: Avoid reading past the end of the indices array. Spotted by Marcus Meissner. --- dlls/gdi32/dibdrv/graphics.c | 3 ++- dlls/gdi32/font.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/gdi32/dibdrv/graphics.c b/dlls/gdi32/dibdrv/graphics.c index 590a816..d0c0afe 100644 --- a/dlls/gdi32/dibdrv/graphics.c +++ b/dlls/gdi32/dibdrv/graphics.c @@ -192,8 +192,9 @@ static DWORD get_glyph_bitmap( HDC hdc, UINT index, UINT aa_flags, GLYPHMETRICS indices[0] = index; - for (i = 0; i < sizeof(indices) / sizeof(indices[0]); index = indices[++i]) + for (i = 0; i < sizeof(indices) / sizeof(indices[0]); i++) { + index = indices[i]; ret = GetGlyphOutlineW( hdc, index, ggo_flags, metrics, 0, NULL, &identity ); if (ret != GDI_ERROR) break; } diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c index 0f01a92..5b7d500 100644 --- a/dlls/gdi32/font.c +++ b/dlls/gdi32/font.c @@ -1640,8 +1640,9 @@ static DWORD get_glyph_bitmap( HDC hdc, UINT index, UINT aa_flags, indices[0] = index; - for (i = 0; i < sizeof(indices) / sizeof(indices[0]); index = indices[++i]) + for (i = 0; i < sizeof(indices) / sizeof(indices[0]); i++) { + index = indices[i]; ret = GetGlyphOutlineW( hdc, index, ggo_flags, metrics, 0, NULL, &identity ); if (ret != GDI_ERROR) break; }
1
0
0
0
Huw Davies : gdi32: Add an option to allow pen_lines to draw a closed figure.
by Alexandre Julliard
24 Nov '11
24 Nov '11
Module: wine Branch: master Commit: 224e51fcf55ee4b4c34550084c39b63365cdffa4 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=224e51fcf55ee4b4c34550084…
Author: Huw Davies <huw(a)codeweavers.com> Date: Thu Nov 24 09:26:44 2011 +0000 gdi32: Add an option to allow pen_lines to draw a closed figure. --- dlls/gdi32/dibdrv/dibdrv.h | 2 +- dlls/gdi32/dibdrv/graphics.c | 11 +++++------ dlls/gdi32/dibdrv/objects.c | 10 +++++++--- 3 files changed, 13 insertions(+), 10 deletions(-) diff --git a/dlls/gdi32/dibdrv/dibdrv.h b/dlls/gdi32/dibdrv/dibdrv.h index 3e3ab21..4068b54 100644 --- a/dlls/gdi32/dibdrv/dibdrv.h +++ b/dlls/gdi32/dibdrv/dibdrv.h @@ -87,7 +87,7 @@ typedef struct dibdrv_physdev DWORD pen_color, pen_and, pen_xor; dash_pattern pen_pattern; dash_pos dash_pos; - BOOL (* pen_lines)(struct dibdrv_physdev *pdev, int num, POINT *pts); + BOOL (* pen_lines)(struct dibdrv_physdev *pdev, int num, POINT *pts, BOOL close); /* brush */ UINT brush_style; diff --git a/dlls/gdi32/dibdrv/graphics.c b/dlls/gdi32/dibdrv/graphics.c index d5e4730..590a816 100644 --- a/dlls/gdi32/dibdrv/graphics.c +++ b/dlls/gdi32/dibdrv/graphics.c @@ -431,7 +431,7 @@ BOOL dibdrv_LineTo( PHYSDEV dev, INT x, INT y ) reset_dash_origin(pdev); - if(defer_pen(pdev) || !pdev->pen_lines(pdev, 2, pts)) + if(defer_pen(pdev) || !pdev->pen_lines(pdev, 2, pts, FALSE)) return next->funcs->pLineTo( next, x, y ); return TRUE; @@ -528,7 +528,7 @@ BOOL dibdrv_PolyPolyline( PHYSDEV dev, const POINT* pt, const DWORD* counts, DWO LPtoDP( dev->hdc, points, counts[i] ); reset_dash_origin( pdev ); - pdev->pen_lines( pdev, counts[i], points ); + pdev->pen_lines( pdev, counts[i], points, FALSE ); } HeapFree( GetProcessHeap(), 0, points ); @@ -553,7 +553,7 @@ BOOL dibdrv_Polyline( PHYSDEV dev, const POINT* pt, INT count ) LPtoDP( dev->hdc, points, count ); reset_dash_origin( pdev ); - pdev->pen_lines( pdev, count, points ); + pdev->pen_lines( pdev, count, points, FALSE ); HeapFree( GetProcessHeap(), 0, points ); return TRUE; @@ -567,7 +567,7 @@ BOOL dibdrv_Rectangle( PHYSDEV dev, INT left, INT top, INT right, INT bottom ) PHYSDEV next = GET_NEXT_PHYSDEV( dev, pRectangle ); dibdrv_physdev *pdev = get_dibdrv_pdev(dev); RECT rect = get_device_rect( dev->hdc, left, top, right, bottom, TRUE ); - POINT pts[5]; + POINT pts[4]; TRACE("(%p, %d, %d, %d, %d)\n", dev, left, top, right, bottom); @@ -583,9 +583,8 @@ BOOL dibdrv_Rectangle( PHYSDEV dev, INT left, INT top, INT right, INT bottom ) pts[0].y = pts[1].y = rect.top; pts[1].x = pts[2].x = rect.left; pts[2].y = pts[3].y = rect.bottom - 1; - pts[4] = pts[0]; - pdev->pen_lines(pdev, 5, pts); + pdev->pen_lines(pdev, 4, pts, TRUE); /* FIXME: Will need updating when we support wide pens */ diff --git a/dlls/gdi32/dibdrv/objects.c b/dlls/gdi32/dibdrv/objects.c index 51e1fdc..0baafdb 100644 --- a/dlls/gdi32/dibdrv/objects.c +++ b/dlls/gdi32/dibdrv/objects.c @@ -696,7 +696,7 @@ static BOOL solid_pen_line(dibdrv_physdev *pdev, POINT *start, POINT *end) return TRUE; } -static BOOL solid_pen_lines(dibdrv_physdev *pdev, int num, POINT *pts) +static BOOL solid_pen_lines(dibdrv_physdev *pdev, int num, POINT *pts, BOOL close) { int i; @@ -705,6 +705,8 @@ static BOOL solid_pen_lines(dibdrv_physdev *pdev, int num, POINT *pts) if (!solid_pen_line( pdev, pts + i, pts + i + 1 )) return FALSE; + if (close) return solid_pen_line( pdev, pts + num - 1, pts ); + return TRUE; } @@ -996,7 +998,7 @@ static BOOL dashed_pen_line(dibdrv_physdev *pdev, POINT *start, POINT *end) return TRUE; } -static BOOL dashed_pen_lines(dibdrv_physdev *pdev, int num, POINT *pts) +static BOOL dashed_pen_lines(dibdrv_physdev *pdev, int num, POINT *pts, BOOL close) { int i; @@ -1005,10 +1007,12 @@ static BOOL dashed_pen_lines(dibdrv_physdev *pdev, int num, POINT *pts) if (!dashed_pen_line( pdev, pts + i, pts + i + 1 )) return FALSE; + if (close) return dashed_pen_line( pdev, pts + num - 1, pts ); + return TRUE; } -static BOOL null_pen_lines(dibdrv_physdev *pdev, int num, POINT *pts) +static BOOL null_pen_lines(dibdrv_physdev *pdev, int num, POINT *pts, BOOL close) { return TRUE; }
1
0
0
0
Francois Gouget : include: Update winuser.rh.
by Alexandre Julliard
24 Nov '11
24 Nov '11
Module: wine Branch: master Commit: 8342d5049f01eb96fe7aaf004a8c02325cd01194 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=8342d5049f01eb96fe7aaf004…
Author: Francois Gouget <fgouget(a)free.fr> Date: Thu Nov 24 00:25:14 2011 +0100 include: Update winuser.rh. --- include/winuser.rh | 84 +++++++++++++++++++++++++++++++++++++++++++-------- 1 files changed, 70 insertions(+), 14 deletions(-) diff --git a/include/winuser.rh b/include/winuser.rh index f8f99fb..1d2a0bb 100644 --- a/include/winuser.rh +++ b/include/winuser.rh @@ -56,6 +56,13 @@ #define SW_MAX 11 #define SW_NORMALNA 0xCC /* Undocumented. Flag in MinMaximize */ +/* Obsolete ShowWindow() codes for compatibility */ +#define HIDE_WINDOW SW_HIDE +#define SHOW_OPENWINDOW SW_SHOWNORMAL +#define SHOW_ICONWINDOW SW_SHOWMINIMIZED +#define SHOW_FULLSCREEN SW_SHOWMAXIMIZED +#define SHOW_OPENNOACTIVATE SW_SHOWNOACTIVATE + /* WM_SHOWWINDOW lParam codes */ #define SW_PARENTCLOSING 1 #define SW_OTHERZOOM 2 @@ -223,12 +230,24 @@ #define VK_ICO_HELP 0xE3 /* Help key on ICO */ #define VK_ICO_00 0xE4 /* 00 key on ICO */ #define VK_PROCESSKEY 0xE5 -/* 0xE6 OEM specific */ +#define VK_ICO_CLEAR 0xE6 #define VK_PACKET 0xE7 /* 0xE8 Unassigned */ -/* 0xE9-0xF5 OEM specific */ +#define VK_OEM_RESET 0xE9 +#define VK_OEM_JUMP 0xEA +#define VK_OEM_PA1 0xEB +#define VK_OEM_PA2 0xEC +#define VK_OEM_PA3 0xED +#define VK_OEM_WSCTRL 0xEE +#define VK_OEM_CUSEL 0xEF +#define VK_OEM_ATTN 0xF0 +#define VK_OEM_FINISH 0xF1 +#define VK_OEM_COPY 0xF2 +#define VK_OEM_AUTO 0xF3 +#define VK_OEM_ENLW 0xF4 +#define VK_OEM_BACKTAB 0xF5 #define VK_ATTN 0xF6 #define VK_CRSEL 0xF7 #define VK_EXSEL 0xF8 @@ -274,7 +293,7 @@ #define WM_ENDSESSION 0x0016 #define WM_SYSTEMERROR 0x0017 /* DDK / Win16 */ #define WM_SHOWWINDOW 0x0018 -#define WM_CTLCOLOR 0x0019 +#define WM_CTLCOLOR 0x0019 /* Added from windowsx.h */ #define WM_WININICHANGE 0x001a #define WM_SETTINGCHANGE WM_WININICHANGE #define WM_DEVMODECHANGE 0x001b @@ -322,6 +341,13 @@ #define WM_POWER 0x0048 +/* For WM_POWER */ +#define PWR_OK 1 +#define PWR_FAIL (-1) +#define PWR_SUSPENDREQUEST 1 +#define PWR_SUSPENDRESUME 2 +#define PWR_CRITICALRESUME 3 + /* Win32 4.0 messages */ #define WM_COPYDATA 0x004a #define WM_CANCELJOURNAL 0x004b @@ -412,6 +438,8 @@ /* Menu messages */ #define WM_INITMENU 0x0116 #define WM_INITMENUPOPUP 0x0117 +#define WM_GESTURE 0x0119 +#define WM_GESTURENOTIFY 0x011A #define WM_MENUSELECT 0x011F #define WM_MENUCHAR 0x0120 @@ -474,6 +502,9 @@ #define GET_WHEEL_DELTA_WPARAM(wParam) ((short)HIWORD(wParam)) #define WHEEL_PAGESCROLL (UINT_MAX) +#define GET_KEYSTATE_WPARAM(wParam) (LOWORD(wParam)) +#define GET_NCHITTEST_WPARAM(wParam) ((short)LOWORD(wParam)) +#define GET_XBUTTON_WPARAM(wParam) (HIWORD(wParam)) #define XBUTTON1 0x0001 #define XBUTTON2 0x0002 @@ -514,6 +545,8 @@ #define WM_EXITSIZEMOVE 0x0232 #define WM_DROPFILES 0x0233 +#define WM_TOUCH 0x0240 + /* Win32 4.0 messages for IME */ #define WM_IME_SETCONTEXT 0x0281 #define WM_IME_NOTIFY 0x0282 @@ -574,6 +607,8 @@ #define WM_DWMNCRENDERINGCHANGED 0x031F #define WM_DWMCOLORIZATIONCOLORCHANGED 0x0320 #define WM_DWMWINDOWMAXIMIZEDCHANGE 0x0321 +#define WM_DWMSENDICONICTHUMBNAIL 0x0323 +#define WM_DWMSENDICONICLIVEPREVIEWBITMAP 0x0326 #define WM_GETTITLEBARINFOEX 0x033F @@ -609,12 +644,16 @@ #define HTCAPTION 2 #define HTSYSMENU 3 #define HTSIZE 4 +#define HTGROWBOX HTSIZE #define HTMENU 5 #define HTHSCROLL 6 #define HTVSCROLL 7 #define HTMINBUTTON 8 +#define HTREDUCE HTMINBUTTON #define HTMAXBUTTON 9 +#define HTZOOM HTMAXBUTTON #define HTLEFT 10 +#define HTSIZEFIRST HTLEFT #define HTRIGHT 11 #define HTTOP 12 #define HTTOPLEFT 13 @@ -622,21 +661,18 @@ #define HTBOTTOM 15 #define HTBOTTOMLEFT 16 #define HTBOTTOMRIGHT 17 +#define HTSIZELAST HTBOTTOMRIGHT #define HTBORDER 18 -#define HTGROWBOX HTSIZE -#define HTREDUCE HTMINBUTTON -#define HTZOOM HTMAXBUTTON #define HTOBJECT 19 #define HTCLOSE 20 #define HTHELP 21 -#define HTSIZEFIRST HTLEFT -#define HTSIZELAST HTBOTTOMRIGHT /* SendMessageTimeout flags */ #define SMTO_NORMAL 0x0000 #define SMTO_BLOCK 0x0001 #define SMTO_ABORTIFHUNG 0x0002 #define SMTO_NOTIMEOUTIFNOTHUNG 0x0008 +#define SMTO_ERRORONEXIT 0x0020 /* WM_MOUSEACTIVATE return values */ #define MA_ACTIVATE 1 @@ -754,8 +790,8 @@ #define WS_EX_COMPOSITED __MSABI_LONG(0x02000000) #define WS_EX_NOACTIVATE __MSABI_LONG(0x08000000) -#define WS_EX_OVERLAPPEDWINDOW (WS_EX_WINDOWEDGE|WS_EX_CLIENTEDGE) -#define WS_EX_PALETTEWINDOW (WS_EX_WINDOWEDGE|WS_EX_TOOLWINDOW|WS_EX_TOPMOST) +#define WS_EX_OVERLAPPEDWINDOW (WS_EX_WINDOWEDGE | WS_EX_CLIENTEDGE) +#define WS_EX_PALETTEWINDOW (WS_EX_WINDOWEDGE | WS_EX_TOOLWINDOW | WS_EX_TOPMOST) #endif /* NOWINSTYLES */ @@ -908,6 +944,9 @@ #define SC_CONTEXTHELP 0xf180 #define SC_SEPARATOR 0xf00f +#define GET_SC_WPARAM(wParam) ((int)wParam & 0xfff0) +#define SCF_ISSECURE 0x0001 + /* Obsolete names */ #define SC_ICON SC_MINIMIZE #define SC_ZOOM SC_MAXIMIZE @@ -916,6 +955,9 @@ /*** OEM Resource Ordinal Numbers ***/ #ifdef OEMRESOURCE +#define OBM_RDRVERT 32559 +#define OBM_RDRHORZ 32660 +#define OBM_RDR2DIM 32661 #define OBM_TRTYPE 32732 /* FIXME: Wine-only */ #define OBM_LFARROWI 32734 #define OBM_RGARROWI 32735 @@ -969,7 +1011,18 @@ #define OCR_HAND 32649 #define OCR_APPSTARTING 32650 #define OCR_HELP 32651 /* DDK / Win16 */ -#define OCR_DRAGOBJECT 32653 /* FIXME: Wine-only */ +#define OCR_RDRVERT 32652 /* DDK / Win16 */ +#define OCR_RDRHORZ 32653 /* DDK / Win16 */ +#define OCR_DRAGOBJECT OCR_RDRHORZ /* FIXME: Wine-only */ +#define OCR_RDR2DIM 32654 /* DDK / Win16 */ +#define OCR_RDRNORTH 32655 /* DDK / Win16 */ +#define OCR_RDRSOUTH 32656 /* DDK / Win16 */ +#define OCR_RDRWEST 32657 /* DDK / Win16 */ +#define OCR_RDREAST 32658 /* DDK / Win16 */ +#define OCR_RDRNORTHWEST 32659 /* DDK / Win16 */ +#define OCR_RDRNORTHEAST 32660 /* DDK / Win16 */ +#define OCR_RDRSOUTHWEST 32661 /* DDK / Win16 */ +#define OCR_RDRSOUTHEAST 32662 /* DDK / Win16 */ #define OIC_SAMPLE 32512 #define OIC_HAND 32513 @@ -980,6 +1033,7 @@ #define OIC_NOTE 32516 #define OIC_INFORMATION OIC_NOTE #define OIC_WINLOGO 32517 +#define OIC_SHIELD 32518 #endif /* OEMRESOURCE */ @@ -991,6 +1045,7 @@ #define IDI_EXCLAMATION MAKEINTRESOURCE(32515) #define IDI_ASTERISK MAKEINTRESOURCE(32516) #define IDI_WINLOGO MAKEINTRESOURCE(32517) +#define IDI_SHIELD MAKEINTRESOURCE(32518) #define IDI_WARNING IDI_EXCLAMATION #define IDI_ERROR IDI_HAND @@ -1052,10 +1107,10 @@ #define EM_SETHANDLE 0x00bc #define EM_GETHANDLE 0x00bd #define EM_GETTHUMB 0x00be -/* FIXME : missing from specs 0x00bf and 0x00c0 */ +/* Unassigned 0x00bf and 0x00c0 */ #define EM_LINELENGTH 0x00c1 #define EM_REPLACESEL 0x00c2 -/* FIXME : missing from specs 0x00c3 */ +#define EM_SETFONT 0x00c3 /* DDK / Win16 */ #define EM_GETLINE 0x00c4 #define EM_LIMITTEXT 0x00c5 #define EM_SETLIMITTEXT EM_LIMITTEXT @@ -1063,7 +1118,7 @@ #define EM_UNDO 0x00c7 #define EM_FMTLINES 0x00c8 #define EM_LINEFROMCHAR 0x00c9 -/* FIXME : missing from specs 0x00ca */ +#define EM_SETWORDBREAK 0x00ca /* DDK / Win16 */ #define EM_SETTABSTOPS 0x00cb #define EM_SETPASSWORDCHAR 0x00cc #define EM_EMPTYUNDOBUFFER 0x00cd @@ -1137,6 +1192,7 @@ #define BM_CLICK 0x00f5 #define BM_GETIMAGE 0x00f6 #define BM_SETIMAGE 0x00f7 +#define BM_SETDONTCLICK 0x00f8 /* Button states */ #define BST_UNCHECKED 0x0000
1
0
0
0
← Newer
1
...
13
14
15
16
17
18
19
...
86
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
Results per page:
10
25
50
100
200