Alexandre Julliard pushed to branch master at wine / wine
Commits:
ac3e150f by Arkadiusz Hiler at 2025-02-25T23:02:48+01:00
krnl386: Silence a warning in GetSystemDirectory16().
With GCC 14.2 on Debian 11:
$ i686-w64-mingw32-gcc --version
i686-w64-mingw32-gcc (GCC) 14.2.0
Copyright (C) 2024 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
The following error happens:
In file included from ~/src/wine/dlls/krnl386.exe16/file.c:33:
In function 'lstrcpyA',
inlined from 'GetSystemDirectory16' at ~/src/wine/dlls/krnl386.exe16/file.c:648:9,
inlined from 'get_search_path' at ~/src/wine/dlls/krnl386.exe16/file.c:192:12:
~/src/wine/include/winbase.h:2939:12: error: argument 1 null where non-null expected [-Werror=nonnull]
2939 | return strcpy( dst, src );
| ^~~~~~~~~~~~~~~~~~
In file included from ~/src/wine/dlls/krnl386.exe16/file.c:28:
~/src/wine/include/msvcrt/string.h: In function 'get_search_path':
~/src/wine/include/msvcrt/string.h:53:26: note: in a call to function 'strcpy' declared 'nonnull'
53 | _ACRTIMP char* __cdecl strcpy(char*,const char*);
| ^~~~~~
In function 'lstrcatA',
inlined from 'GetSystemDirectory16' at ~/src/wine/dlls/krnl386.exe16/file.c:649:9,
inlined from 'get_search_path' at ~/src/wine/dlls/krnl386.exe16/file.c:192:12:
~/src/wine/include/winbase.h:2952:12: error: argument 1 null where non-null expected [-Werror=nonnull]
2952 | return strcat( dst, src );
| ^~~~~~~~~~~~~~~~~~
~/src/wine/include/winbase.h:2952:12: note: in a call to built-in function '__builtin_strlen'
(built using --with-mingw and --enable-werror to turn it into an error)
The warning doesn't really matter as get_search_path() calls
GetSystemDirectory16(NULL, 0) to get the size for allocation.
`if (count >= len)` in the latter saves us from ever atempting to
strcpy() onto NULL, but the compiler is not smart enough to figure out
that len will be greater than 0.
This change mimics kernel32's GetSystemDirectoryW().
- - - - -
1 changed file:
- dlls/krnl386.exe16/file.c
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/commit/ac3e150f283bdaffaa15827b02f9fb…
--
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/commit/ac3e150f283bdaffaa15827b02f9fb…
You're receiving this email because of your account on gitlab.winehq.org.
Alexandre Julliard pushed to branch master at wine / wine
Commits:
31c33ef3 by Alexandre Julliard at 2025-02-25T23:01:11+01:00
configure: Check that the 32- and 64-bit builds are using the same libdir.
- - - - -
dc718fd3 by Alexandre Julliard at 2025-02-25T23:01:11+01:00
ntdll: Add some missing Zw exports.
- - - - -
eb08d2f8 by Alexandre Julliard at 2025-02-25T23:02:41+01:00
apisetschema: Add some new apisets, and old ones for recently added dlls.
- - - - -
4 changed files:
- configure
- configure.ac
- dlls/apisetschema/apisetschema.spec
- dlls/ntdll/ntdll.spec
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/compare/900fb8793986ae6ed1a8dd4700ab9…
--
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/compare/900fb8793986ae6ed1a8dd4700ab9…
You're receiving this email because of your account on gitlab.winehq.org.
Alexandre Julliard pushed to branch master at wine / wine
Commits:
487a336e by Zhiyi Zhang at 2025-02-25T23:01:11+01:00
imm32/tests: Test that the IME UI window shouldn't be above normal windows at creation.
- - - - -
1ac9ae87 by Zhiyi Zhang at 2025-02-25T23:01:11+01:00
imm32: Move the IME UI window to the bottom at creation.
Tidy Cauldron (2708320), a Unity game, uses EnumWindows() to find the first window in the current
thread and maximizes the window when changing to windowed mode. However, before this patch, the IME
UI window and the DXGI fallback device window are on top of the game window at creation and thus
they could get maximized instead. This causes the game window to lose focus and freeze.
- - - - -
90318862 by Zhiyi Zhang at 2025-02-25T23:01:11+01:00
d3d11/tests: Test that the fallback device window shouldn't be above normal windows at creation.
- - - - -
900fb879 by Zhiyi Zhang at 2025-02-25T23:01:11+01:00
dxgi: Move the fallback device window to the bottom at creation.
Tidy Cauldron (2708320), a Unity game, uses EnumWindows() to find the first window in the current
thread and maximizes the window when changing to windowed mode. However, before this patch, the IME
UI window and the DXGI fallback device window are on top of the game window at creation and thus
they could get maximized instead. This causes the game window to lose focus and freeze.
- - - - -
4 changed files:
- dlls/d3d11/tests/d3d11.c
- dlls/dxgi/factory.c
- dlls/imm32/imm.c
- dlls/imm32/tests/imm32.c
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/compare/76cf681a65b8e218dfbdf31145914…
--
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/compare/76cf681a65b8e218dfbdf31145914…
You're receiving this email because of your account on gitlab.winehq.org.
Alexandre Julliard pushed to branch master at wine / wine
Commits:
9f0883c6 by Brendan McGrath at 2025-02-24T22:55:46+01:00
mp3dmod/tests: Add tests for selecting an invalid stream.
- - - - -
5b12f945 by Brendan McGrath at 2025-02-24T22:55:46+01:00
mp3dmod: Check for invalid stream.
- - - - -
13eafd85 by Brendan McGrath at 2025-02-24T22:55:46+01:00
mp3dmod/tests: Add tests for GetInputCurrentType.
- - - - -
daac091b by Brendan McGrath at 2025-02-24T22:55:46+01:00
mp3dmod/tests: Add tests for GetOutputCurrentType.
- - - - -
8da51968 by Brendan McGrath at 2025-02-24T22:55:46+01:00
mp3dmod: Implement GetInputCurrentType.
- - - - -
ce090343 by Brendan McGrath at 2025-02-24T22:55:46+01:00
mp3dmod: Implement GetOutputCurrentType.
- - - - -
4c06d354 by Brendan McGrath at 2025-02-24T22:55:46+01:00
mp3dmod: Fix leak of previous outtype.
- - - - -
2 changed files:
- dlls/mp3dmod/mp3dmod.c
- dlls/mp3dmod/tests/mp3dmod.c
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/compare/c09cf04b6f7ea2a2f82865aeadca2…
--
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/compare/c09cf04b6f7ea2a2f82865aeadca2…
You're receiving this email because of your account on gitlab.winehq.org.
Alexandre Julliard pushed to branch master at wine / wine
Commits:
a33d8e4d by Eric Pouech at 2025-02-24T22:55:46+01:00
findstr/tests: Add test for default findstr regex vs text search mode.
Signed-off-by: Eric Pouech <epouech(a)codeweavers.com>
- - - - -
b29952f5 by Eric Pouech at 2025-02-24T22:55:46+01:00
findstr: Set default search mode to regex.
Spotted by Chromium test suite.
Signed-off-by: Eric Pouech <epouech(a)codeweavers.com>
- - - - -
2529a6bc by Eric Pouech at 2025-02-24T22:55:46+01:00
findstr/tests: Always set text/regex search mode in tests.
(mainly for the tests without mode, which were written with textual mode in
mind, yet run in regex mode)
Signed-off-by: Eric Pouech <epouech(a)codeweavers.com>
- - - - -
2 changed files:
- programs/findstr/main.c
- programs/findstr/tests/findstr.c
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/compare/dec96acdc75dc5b64c75b9edbed14…
--
View it on GitLab: https://gitlab.winehq.org/wine/wine/-/compare/dec96acdc75dc5b64c75b9edbed14…
You're receiving this email because of your account on gitlab.winehq.org.