wine-devel January 2008

wine-devel@winehq.org

126 participants
290 discussions

Another serial port trouble report
by Dan Kegel 10 Jan '08

10 Jan '08

http://www.chiefdelphi.com/forums/showthread.php?t=61219 complains that IFI_Loader doesn't work at all in Wine. I haven't tried doing serial I/O with it, but it installs and starts fine. If somebody who's into serial I/O could give it a spin, it might turn up some problems. (Or maybe they were just using an old version of wine, who knows.) -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: shdocvw: change return value for PersistMemory_Load
by Jacek Caban 10 Jan '08

10 Jan '08

Louis. Lenders wrote: > Hi, i send this to wine-patches for review (by Jacek i guess). A user > submitted garbage test results for Segamic: > http://prdownloads.sourceforge.net/semagic/Semagic1709for2k.exe?download > > It's the second time i see an app failing on PersistMemory_Load > returning E_NOTIMPL. > Attached patch makes the app start fine. I know faking success return > value can have unwanted side effects, but for this one it seems to be > quite harmless. Also helps a bit for > http://bugs.winehq.org/show_bug.cgi?id=10588 > > Jacek, if you think it could cause trouble could you give a response? I think this patch is fine and it may go to Git. Thanks, Jacek

1 0

Re: WineD3D: Spelling fixes.
by Jonathan Ernst 10 Jan '08

10 Jan '08

On jeu, 2008-01-10 at 10:53 -0600, Austin English wrote: > - * which is essentially an input, is the destiantion register > because it is the first > - * param. According to the msdn, this must be register r5, but > let's keep it more flexible > + * which is essentially an input, is the destination register > because it is the first > + * paramater. According to the msdn, this must be register r5, > but let's keep it more flexible paramEter ?

2 1

Re: [1/2] d3dx9: Implement the different dlls [try 2]
by tony.wasserka＠freenet.de 10 Jan '08

10 Jan '08

> Please stop resending that big patch again and again, it's not going in, > it's full of problems. You need to provide correct forwards for all > functions instead of stubs, and the functions need to match the Windows > ones, you can't just copy the same spec file 12 times. Also the code was > written by David, you have to use his name in the changelog, and you > shouldn't add your copyright in all the files unless you make > significant changes. Okay, I now have spent some time on analysing the differences of the dlls (at least regarding to what functions they provide). So just a few questions from my side to make sure the next version of the patch will be what you expect: 1. Really just to ensure that one: You DO want me to forward even the stubbed functions to the "d3dx9_36 stubs", don't you? If there's more to the forwards, then tell me please. 2. Regarding the copyright thing, I'm really sorry for ignoring David's copyright, I'll change that back. However, you didn't mean the git changelog with "use his name in the changelog", did you? Well, if you did, It'd be possible to mention both, as I'll have rewritten all the specfiles. (It's not that I wouldn't respect David for his work, but the time I spent on this shouldn't be left out either) 3. When it's ready, should I post my patch to a pastebin and ask at #winehackers first if it's ok like that? 4. Is there anything other that I should correct?

2 1

major regression in current git
by Steven Edwards 10 Jan '08

10 Jan '08

Hi, Sorry I've not filed a bug report for this or dug in to it more, I am a little short on time. I've got a clean tree and am trying to install Office 97 and it seems to have totally regressed. A clean build from a few days ago installed flawlessly. I've made clean and reconfigured twice now and still see this behavior. System is ubuntu 7.10 wine: Unhandled page fault on read access to 0x00000000 at address 0xf7d4183c (thread 0016), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0xf7d4183c). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:f7d4183c ESP:0033e464 EBP:0033e490 EFLAGS:00010216( - 00 -RIAP1) EAX:fffffff7 EBX:7d4d2a2c ECX:3ffffff3 EDX:0000000c ESI:00000000 EDI:7c05a7f8 Stack dump: 0x0033e464: 7d4ce808 7c05a7f8 00000000 ffffffcc 0x0033e474: 7e59b560 7e5a232c 0013fde8 00000001 0x0033e484: 7e59b560 7e5a232c 0013fde8 0033e6a0 0x0033e494: 7e5853f2 7c05a0d0 04400082 0033e55c 0x0033e4a4: 0033e550 00000001 00000000 ffffffcc 0x0033e4b4: 00000000 00000000 00000000 00000000 Backtrace: =>1 0xf7d4183c memcpy+0x1c() in libc.so.6 (0x0033e490) 2 0x7e5853f2 UploadGlyph+0x722(physDev=<register EDI not in topmost frame>, glyph=0x24, format=0x1) [/home/sedwards/source/wine-git/dlls/winex11.drv/xrender.c:803] in winex11 (0x0033e6a0) 3 0x7e5872cf X11DRV_XRender_ExtTextOut+0x64f(physDev=0x13fde8, x=0x16, y=0xd, flags=<is not available>, lprect=0x33ecc0, wstr=0x157448, count=0x8, lpDx=0x0) [/home/sedwards/source/wine-git/dlls/winex11.drv/xrender.c:1259] in winex11 (0x0033ea10) 4 0x7e56b75a X11DRV_ExtTextOut+0x5a(physDev=<register EDI not in topmost frame>, x=0x16, y=0xd, flags=0x1010, lprect=0x33ecc0, wstr=0x157448, count=0x8, lpDx=0x0) [/home/sedwards/source/wine-git/dlls/winex11.drv/text.c:55] in winex11 (0x0033eac0) 5 0x7eadcdb7 ExtTextOutW+0xd87(hdc=0x314, x=0x16, y=0xd, flags=0x1010, lprect=0x33f6cc, str=0x33ee04, count=0x8, lpDx=0x0) [/home/sedwards/source/wine-git/dlls/gdi32/font.c:2225] in gdi32 (0x0033ed00) 6 0x7ebe18f5 DrawTextExW+0xf45(hdc=0x314, str=0x157840, i_count=<is not available>, rect=0x33f6cc, flags=0x125, dtp=0x33f698) [/home/sedwards/source/wine-git/dlls/user32/text.c:957] in user32 (0x0033f660) 7 0x7ebe237f DrawTextW+0x6f(hdc=0x314, str=0x157840, count=0xffffffff, rect=0x33f6cc, flags=0x125) [/home/sedwards/source/wine-git/dlls/user32/text.c:1090] in user32 (0x0033f6b0) 8 0x7eb69244 BUTTON_DrawTextCallback+0x54(hdc=0x314, lp=0x157840, wp=0x125, cx=0x21, cy=0xfffffff6) [/home/sedwards/source/wine-git/dlls/user32/button.c:727] in user32 (0x0033f6e0) 9 0x7ebe30fb UITOOLS_DrawStateJam+0x1cb(hdc=0x314, opcode=<is not available>, func=0x7eb691f0, lp=0x157840, wp=0x125, rc=0x33f7ac, dtflags=0x100, unicode=0x1) [/home/sedwards/source/wine-git/dlls/user32/uitools.c:1562] in user32 (0x0033f730) 10 0x7ebe357a UITOOLS_DrawState+0x17a(hdc=0x314, hbr=0x0, func=0x7eb691f0, lp=0x157840, wp=0x125, x=0x16, y=0xe, cx=0x21, cy=0xfffffff6, flags=0x0, unicode=0x1) [/home/sedwards/source/wine-git/dlls/user32/uitools.c:1738] in user32 (0x0033f7d0) 11 0x7ebe3b6c DrawStateW+0x4c(hdc=0x314, hbr=0x0, func=0x7eb691f0, ldata=0x157840, wdata=0x125, x=0x16, y=0xe, cx=0x21, cy=0xfffffff6, flags=0x0) [/home/sedwards/source/wine-git/dlls/user32/uitools.c:1758] in user32 (0x0033f800) 12 0x7eb69a2b BUTTON_DrawLabel+0x16b(hwnd=0x10032, hdc=0x314, dtFlags=0x125, rc=0x33f8a4) [/home/sedwards/source/wine-git/dlls/user32/button.c:781] in user32 (0x0033f860) 13 0x7eb69e9f PB_Paint+0x20f(hwnd=0x10032, hDC=<register EDI not in topmost frame>, action=0x1) [/home/sedwards/source/wine-git/dlls/user32/button.c:858] in user32 (0x0033f8e0) 14 0x7eb6b165 ButtonWndProc_common+0xd85(hWnd=0x10032, uMsg=<is not available>, wParam=0x0, lParam=0x0, unicode=0x1) [/home/sedwards/source/wine-git/dlls/user32/button.c:302] in user32 (0x0033f9d0) 15 0x7eb6bb26 ButtonWndProcW+0x46(hWnd=<register ESI not in topmost frame>, uMsg=0xf, wParam=0x0, lParam=0x0) [/home/sedwards/source/wine-git/dlls/user32/button.c:554] in user32 (0x0033f9f0) 16 0x7ebf23ea WINPROC_wrapper+0x1a() in user32 (0x0033fa20) 17 0x7ebf2ace call_window_proc+0x6e(hwnd=<register EDI not in topmost frame>, msg=0xf, wp=0x0, lp=0x0, result=0x33fad0, arg=0x7eb6bae0) [/home/sedwards/source/wine-git/dlls/user32/winproc.c:457] in user32 (0x0033fa60) 18 0x7ebf8e51 WINPROC_call_window+0xd1(hwnd=<register ESI not in topmost frame>, msg=0xf, wParam=0x0, lParam=0x0, result=0x33fad0, unicode=0x1, mapping=0x4) [/home/sedwards/source/wine-git/dlls/user32/winproc.c:2207] in user32 (0x0033faa0) 19 0x7ebbf096 DispatchMessageW+0x96(msg=<register EDI not in topmost frame>) [/home/sedwards/source/wine-git/dlls/user32/message.c:3108] in user32 (0x0033fae0) 20 0x7eb8b86f IsDialogMessageW+0x10f(hwndDlg=<register ESI not in topmost frame>, msg=0x33fc3c) [/home/sedwards/source/wine-git/dlls/user32/dialog.c:1221] in user32 (0x0033fc20) 21 0x7ebbee38 IsDialogMessageA+0x68(hwndDlg=0x2002c, pmsg=0x33fc9c) [/home/sedwards/source/wine-git/dlls/user32/message.c:2976] in user32 (0x0033fc60) 22 0x1001b31c in mssetup (+0x1b31c) (0x00000000) 0xf7d4183c memcpy+0x1c in libc.so.6: repe movsl (%esi),%es:(%edi) Modules: Module Address Debug info Name (85 modules) PE 400000- 45c000 Deferred acmsetup PE 10000000-10048000 Export mssetup ELF 7bf00000-7bf03000 Deferred <wine-loader> ELF 7cec2000-7ced7000 Deferred midimap<elf> \-PE 7ced0000-7ced7000 \ midimap ELF 7ced7000-7cf28000 Deferred libgcrypt.so.11 ELF 7cf28000-7cf38000 Deferred libtasn1.so.3 ELF 7cf38000-7cf40000 Deferred libkrb5support.so.0 ELF 7cf40000-7cf6e000 Deferred libcrypt.so.1 ELF 7cf6e000-7cfde000 Deferred libgnutls.so.13 ELF 7cfde000-7d003000 Deferred libk5crypto.so.3 ELF 7d003000-7d08b000 Deferred libkrb5.so.3 ELF 7d08b000-7d0b4000 Deferred libgssapi_krb5.so.2 ELF 7d0b4000-7d0e9000 Deferred libcups.so.2 ELF 7d0f3000-7d11a000 Deferred msacm32<elf> \-PE 7d100000-7d11a000 \ msacm32 ELF 7d11a000-7d132000 Deferred msacm32<elf> \-PE 7d120000-7d132000 \ msacm32 ELF 7d132000-7d1c0000 Deferred winmm<elf> \-PE 7d140000-7d1c0000 \ winmm ELF 7d430000-7d434000 Deferred libgpg-error.so.0 ELF 7d43d000-7d43f000 Deferred libkeyutils.so.1 ELF 7d43f000-7d442000 Deferred libcom_err.so.2 ELF 7d462000-7d494000 Deferred uxtheme<elf> \-PE 7d470000-7d494000 \ uxtheme ELF 7d496000-7d49f000 Deferred libxcursor.so.1 ELF 7d49f000-7d4bd000 Deferred imm32<elf> \-PE 7d4b0000-7d4bd000 \ imm32 ELF 7d4bd000-7d4c2000 Deferred libxfixes.so.3 ELF 7d4c2000-7d4c5000 Deferred libxcomposite.so.1 ELF 7d4c5000-7d4cb000 Deferred libxrandr.so.2 ELF 7d4cb000-7d4d3000 Deferred libxrender.so.1 ELF 7d4d3000-7d4d6000 Deferred libxinerama.so.1 ELF 7daf7000-7daf9000 Deferred libnvidia-tls.so.1 ELF 7daf9000-7e37f000 Deferred libglcore.so.1 ELF 7e37f000-7e40b000 Deferred libgl.so.1 ELF 7e40b000-7e410000 Deferred libxdmcp.so.6 ELF 7e410000-7e413000 Deferred libxau.so.6 ELF 7e413000-7e504000 Deferred libx11.so.6 ELF 7e504000-7e512000 Deferred libxext.so.6 ELF 7e512000-7e5a3000 Dwarf winex11<elf> \-PE 7e520000-7e5a3000 \ winex11 ELF 7e623000-7e643000 Deferred libexpat.so.1 ELF 7e643000-7e66e000 Deferred libfontconfig.so.1 ELF 7e66e000-7e683000 Deferred libz.so.1 ELF 7e683000-7e6f3000 Deferred libfreetype.so.6 ELF 7e6f3000-7e7b1000 Deferred comctl32<elf> \-PE 7e700000-7e7b1000 \ comctl32 ELF 7e7b1000-7e80a000 Deferred shlwapi<elf> \-PE 7e7c0000-7e80a000 \ shlwapi ELF 7e80a000-7e911000 Deferred shell32<elf> \-PE 7e820000-7e911000 \ shell32 ELF 7e911000-7e925000 Deferred lz32<elf> \-PE 7e920000-7e925000 \ lz32 ELF 7e925000-7e93f000 Deferred version<elf> \-PE 7e930000-7e93f000 \ version ELF 7e93f000-7e960000 Deferred mpr<elf> \-PE 7e950000-7e960000 \ mpr ELF 7e960000-7e973000 Deferred libresolv.so.2 ELF 7e973000-7e991000 Deferred iphlpapi<elf> \-PE 7e980000-7e991000 \ iphlpapi ELF 7e991000-7e9f1000 Deferred rpcrt4<elf> \-PE 7e9a0000-7e9f1000 \ rpcrt4 ELF 7e9f1000-7ea94000 Deferred ole32<elf> \-PE 7ea00000-7ea94000 \ ole32 ELF 7ea94000-7eb2d000 Dwarf gdi32<elf> \-PE 7eab0000-7eb2d000 \ gdi32 ELF 7eb2d000-7ec6b000 Dwarf user32<elf> \-PE 7eb50000-7ec6b000 \ user32 ELF 7ec6b000-7ecb7000 Deferred advapi32<elf> \-PE 7ec80000-7ecb7000 \ advapi32 ELF 7ecb7000-7ecc2000 Deferred libnss_files.so.2 ELF 7ecc2000-7eccc000 Deferred libnss_nis.so.2 ELF 7eccc000-7ece4000 Deferred libnsl.so.1 ELF 7ece4000-7eced000 Deferred libnss_compat.so.2 ELF 7ee0c000-7ef38000 Deferred kernel32<elf> \-PE 7ee30000-7ef38000 \ kernel32 ELF 7ef38000-7ef5d000 Deferred libm.so.6 ELF 7ef5d000-7f000000 Deferred ntdll<elf> \-PE 7ef70000-7f000000 \ ntdll ELF f7ccb000-f7ccf000 Deferred libdl.so.2 ELF f7ccf000-f7e19000 Export libc.so.6 ELF f7e19000-f7e31000 Deferred libpthread.so.0 ELF f7e32000-f7f46000 Deferred libwine.so.1 ELF f7f48000-f7f66000 Deferred ld-linux.so.2 Threads: process tid prio (all id:s are in hex) 00000015 (D) C:\~MSSETUP.T\~msstfof.t\acmsetup.exe 00000016 0 <== 00000013 00000014 0 0000000f 00000012 0 00000011 0 00000010 0 0000000c 0000000e 0 0000000d 0 0000000a 0000000b 0 Backtrace: =>1 0xf7d4183c memcpy+0x1c() in libc.so.6 (0x0033e490) 2 0x7e5853f2 UploadGlyph+0x722(physDev=<register EDI not in topmost frame>, glyph=0x24, format=0x1) [/home/sedwards/source/wine-git/dlls/winex11.drv/xrender.c:803] in winex11 (0x0033e6a0) 3 0x7e5872cf X11DRV_XRender_ExtTextOut+0x64f(physDev=0x13fde8, x=0x16, y=0xd, flags=<is not available>, lprect=0x33ecc0, wstr=0x157448, count=0x8, lpDx=0x0) [/home/sedwards/source/wine-git/dlls/winex11.drv/xrender.c:1259] in winex11 (0x0033ea10) 4 0x7e56b75a X11DRV_ExtTextOut+0x5a(physDev=<register EDI not in topmost frame>, x=0x16, y=0xd, flags=0x1010, lprect=0x33ecc0, wstr=0x157448, count=0x8, lpDx=0x0) [/home/sedwards/source/wine-git/dlls/winex11.drv/text.c:55] in winex11 (0x0033eac0) 5 0x7eadcdb7 ExtTextOutW+0xd87(hdc=0x314, x=0x16, y=0xd, flags=0x1010, lprect=0x33f6cc, str=0x33ee04, count=0x8, lpDx=0x0) [/home/sedwards/source/wine-git/dlls/gdi32/font.c:2225] in gdi32 (0x0033ed00) 6 0x7ebe18f5 DrawTextExW+0xf45(hdc=0x314, str=0x157840, i_count=<is not available>, rect=0x33f6cc, flags=0x125, dtp=0x33f698) [/home/sedwards/source/wine-git/dlls/user32/text.c:957] in user32 (0x0033f660) 7 0x7ebe237f DrawTextW+0x6f(hdc=0x314, str=0x157840, count=0xffffffff, rect=0x33f6cc, flags=0x125) [/home/sedwards/source/wine-git/dlls/user32/text.c:1090] in user32 (0x0033f6b0) 8 0x7eb69244 BUTTON_DrawTextCallback+0x54(hdc=0x314, lp=0x157840, wp=0x125, cx=0x21, cy=0xfffffff6) [/home/sedwards/source/wine-git/dlls/user32/button.c:727] in user32 (0x0033f6e0) 9 0x7ebe30fb UITOOLS_DrawStateJam+0x1cb(hdc=0x314, opcode=<is not available>, func=0x7eb691f0, lp=0x157840, wp=0x125, rc=0x33f7ac, dtflags=0x100, unicode=0x1) [/home/sedwards/source/wine-git/dlls/user32/uitools.c:1562] in user32 (0x0033f730) 10 0x7ebe357a UITOOLS_DrawState+0x17a(hdc=0x314, hbr=0x0, func=0x7eb691f0, lp=0x157840, wp=0x125, x=0x16, y=0xe, cx=0x21, cy=0xfffffff6, flags=0x0, unicode=0x1) [/home/sedwards/source/wine-git/dlls/user32/uitools.c:1738] in user32 (0x0033f7d0) 11 0x7ebe3b6c DrawStateW+0x4c(hdc=0x314, hbr=0x0, func=0x7eb691f0, ldata=0x157840, wdata=0x125, x=0x16, y=0xe, cx=0x21, cy=0xfffffff6, flags=0x0) [/home/sedwards/source/wine-git/dlls/user32/uitools.c:1758] in user32 (0x0033f800) 12 0x7eb69a2b BUTTON_DrawLabel+0x16b(hwnd=0x10032, hdc=0x314, dtFlags=0x125, rc=0x33f8a4) [/home/sedwards/source/wine-git/dlls/user32/button.c:781] in user32 (0x0033f860) 13 0x7eb69e9f PB_Paint+0x20f(hwnd=0x10032, hDC=<register EDI not in topmost frame>, action=0x1) [/home/sedwards/source/wine-git/dlls/user32/button.c:858] in user32 (0x0033f8e0) 14 0x7eb6b165 ButtonWndProc_common+0xd85(hWnd=0x10032, uMsg=<is not available>, wParam=0x0, lParam=0x0, unicode=0x1) [/home/sedwards/source/wine-git/dlls/user32/button.c:302] in user32 (0x0033f9d0) 15 0x7eb6bb26 ButtonWndProcW+0x46(hWnd=<register ESI not in topmost frame>, uMsg=0xf, wParam=0x0, lParam=0x0) [/home/sedwards/source/wine-git/dlls/user32/button.c:554] in user32 (0x0033f9f0) 16 0x7ebf23ea WINPROC_wrapper+0x1a() in user32 (0x0033fa20) 17 0x7ebf2ace call_window_proc+0x6e(hwnd=<register EDI not in topmost frame>, msg=0xf, wp=0x0, lp=0x0, result=0x33fad0, arg=0x7eb6bae0) [/home/sedwards/source/wine-git/dlls/user32/winproc.c:457] in user32 (0x0033fa60) 18 0x7ebf8e51 WINPROC_call_window+0xd1(hwnd=<register ESI not in topmost frame>, msg=0xf, wParam=0x0, lParam=0x0, result=0x33fad0, unicode=0x1, mapping=0x4) [/home/sedwards/source/wine-git/dlls/user32/winproc.c:2207] in user32 (0x0033faa0) 19 0x7ebbf096 DispatchMessageW+0x96(msg=<register EDI not in topmost frame>) [/home/sedwards/source/wine-git/dlls/user32/message.c:3108] in user32 (0x0033fae0) 20 0x7eb8b86f IsDialogMessageW+0x10f(hwndDlg=<register ESI not in topmost frame>, msg=0x33fc3c) [/home/sedwards/source/wine-git/dlls/user32/dialog.c:1221] in user32 (0x0033fc20) 21 0x7ebbee38 IsDialogMessageA+0x68(hwndDlg=0x2002c, pmsg=0x33fc9c) [/home/sedwards/source/wine-git/dlls/user32/message.c:2976] in user32 (0x0033fc60) 22 0x1001b31c in mssetup (+0x1b31c) (0x00000000) -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

3 3

Re: [resend] wineboot: fix installation of SFP protected files
by Alexandre Julliard 10 Jan '08

10 Jan '08

Andrey Turkin <andrey.turkin(a)gmail.com> writes: > @@ -494,7 +494,11 @@ static int ProcessWindowsFileProtection(void) > strcatW( dllcache, dllcacheW ); > } > > - find_handle = FindFirstFileW(dllcache,&finddata); > + dllcache_wildcard = HeapAlloc(GetProcessHeap(), 0, strlenW( dllcache )*sizeof(WCHAR) + sizeof(wildcardW)); > + strcpyW(dllcache_wildcard,dllcache); > + strcatW(dllcache_wildcard,wildcardW); > + > + find_handle = FindFirstFileW( dllcache_wildcard, &finddata ); You could simply remove the wildcard from the end of string after FindFirstFile, no need to copy the whole string. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [advapi32] QueryServiceConfig2 (resend)
by Alexandre Julliard 10 Jan '08

10 Jan '08

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > +#define MAP_STR(str) \ > + do { \ > + if (configW->str) \ > + { \ > + DWORD sz = WideCharToMultiByte( CP_ACP, 0, configW->str, -1, p, n, NULL, NULL ); \ > + if (!sz) { \ > + FIXME("WideCharToMultiByte failed for configW->%s\n", #str ); \ > + ret = FALSE; \ > + goto cleanup; \ > + } \ > + configA->str = p; \ > + p += sz; \ > + n -= sz; \ > + } \ > + else configA->str = NULL; \ > + } while (0) > + > + switch(dwLevel) { > + case SERVICE_CONFIG_DESCRIPTION: > + { LPSERVICE_DESCRIPTIONA configA = (LPSERVICE_DESCRIPTIONA) buffer; > + LPSERVICE_DESCRIPTIONW configW = (LPSERVICE_DESCRIPTIONW) bufferW; > + p = (LPSTR)(configA + 1); > + n = size - sizeof(SERVICE_DESCRIPTIONA); > + MAP_STR(lpDescription); > + } That's ugly, please get rid of that macro. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] d3dx9: Implement the different dlls [try 2]
by Alexandre Julliard 10 Jan '08

10 Jan '08

tony.wasserka(a)freenet.de writes: > Forwarding d3dx9_24...35 functions to d3dx9_36 now. Please stop resending that big patch again and again, it's not going in, it's full of problems. You need to provide correct forwards for all functions instead of stubs, and the functions need to match the Windows ones, you can't just copy the same spec file 12 times. Also the code was written by David, you have to use his name in the changelog, and you shouldn't add your copyright in all the files unless you make significant changes. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] remove strange condition which might lead to crash
by Hans Leidekker 10 Jan '08

10 Jan '08

On Thursday 10 January 2008 09:49:47 Marcus Meissner wrote: > Coverity spotted "arg" as potentially NULL dereferenced > and the originating condition looks broken to me. > > It should not really handle "delim", but just check arg. Agreed, but there's another occurrence of this check in msvcrt_argvtos which has been there all along. Did Coverity spot that one too? -Hans

2 1

Advapi32: Service Control RPC
by Rolf Kalbermatter 10 Jan '08

10 Jan '08

The current service control API directly accesses the registry for most things. In native those fucntions are simple wrappers around RPC calls to the actual service.exe application. Mikolaj Zalewski offered about 3 months ago a possible aproach to implement the service.exe program. In there the proxy code generated through widl directly calls various RPC functions to communicate with the service manager executable. When doing some tests with native advapi32 under Wine I found that those fucntions seem to be implemented by simply calling more or less directly NdrCallClient2. Widl obviously doesn't generate code yet using this API and I'm sure wire compatibility can be achieved without using NdrCallClient2. But a few questions that came up here: - How good or complete is Wine's NdrCallClient(2) implementation? Would it be feasable to use it for the implementation of the service rpc calls? - Assuming it would be not a whole lot of work to make NdrCallClient(2) work for this, would it be desirable to use this API instead of the code generated by widl currently from complexity and/or performance view? - Of course this would mean that widl would have to support (some of) the {Oi | Oic | Oif | Oicf} flags to generate the proxy code but as it seems the necessary code generator at least for the client side would be fairly trivial as it is mostly just a wrapper around NdrClientCall(2) and most of the nitty gritty work is done in in that function. A midl generated proxy code using -Oicf looks at least quite trivial. Any opinions about this anyone? Rolf Kalbermatter

2 3

← Newer
1
...
16
17
18
19
20
21
22
...
29
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel January 2008