wine-devel January 2008

wine-devel@winehq.org

126 participants
290 discussions

Re: user32: Add SetProcessDPIAware stub
by Alexandre Julliard 10 Jan '08

10 Jan '08

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > diff --git a/dlls/user32/winstation.c b/dlls/user32/winstation.c > index 75cb286..ec3a620 100644 > --- a/dlls/user32/winstation.c > +++ b/dlls/user32/winstation.c > @@ -613,3 +613,13 @@ BOOL WINAPI SetUserObjectSecurity( HANDLE handle, PSECURITY_INFORMATION info, > FIXME( "(%p,%p,%p),stub!\n", handle, info, sid ); > return TRUE; > } > + > +/*********************************************************************** > + * SetProcessDPIAware (USER32.@) > + */ > +BOOL WINAPI SetProcessDPIAware( VOID ) > +{ > + FIXME( "stub!\n"); > + > + return TRUE; > +} This has nothing to do with window stations, so it doesn't belong in winstation.c. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: d3dx9: Implement the different dlls
by tony.wasserka＠freenet.de 10 Jan '08

10 Jan '08

Oh okay, I resent a fixed patch. Why isn't it possible to forward the functions of the other dlls to the d3dx8 ones? Or is this just for keeping the code clean so that we don't have mixed d3dx8 and d3dx9_36 forwardings?

3 2

Fwd: [Bug 114025] Re: Problem with wine preloader: Warning: failed to reserve range 00000000-60000000
by Dan Kegel 10 Jan '08

10 Jan '08

Looks like there's a linux platform issue interfering with our preallocations again...? See https://bugs.launchpad.net/bugs/114025 ---------- Forwarded message ---------- From: Kees Cook <kees(a)ubuntu.com> Date: Jan 9, 2008 5:21 PM Subject: [Bug 114025] Re: Problem with wine preloader: Warning: failed to reserve range 00000000-60000000 To: dank06(a)kegel.com This is likely related to the extra security changes added to /etc/sysctl.conf (vm.mmap_min_addr = 65536). As a work-around, set this to 0. Hopefully wine can be built in a way that it doesn't have to reserve the lower 64k all the time. -- Problem with wine preloader: Warning: failed to reserve range 00000000-60000000 https://bugs.launchpad.net/bugs/114025 You received this bug notification because you are a member of Ubuntu Wine Team, which is a bug assignee. -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: Dmitry Timoshkov : gdi32: Add support for scaling font metrics.
by Alistair Leslie-Hughes 10 Jan '08

10 Jan '08

"Alexandre Julliard" <julliard(a)winehq.org> wrote in message news:E1JCHD3-0006Zm-Je@wine.codeweavers.com... > Module: wine > Branch: master > Commit: 535053b92769ce5f020bb6c5516385cf69da5bf4 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=535053b92769ce5f020bb6c55… > > Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> > Date: Tue Jan 8 23:02:09 2008 +0800 > > gdi32: Add support for scaling font metrics. This commit cause my application to fail on loading. Backtrace: 1 0x601bb8ac (0x0219c098) 2 0x672be1cd UploadGlyph+0x33d(physDev=<register EDI not in topmost frame>, glyph=0x34, format=0x1) [/home/alh/wine/dlls/winex11.drv/xrender.c:803] in winex11 (0x0219c2a8) 3 0x672c0088 X11DRV_XRender_ExtTextOut+0x308(physDev=0x1322c0, x=0x0, y=0x9, flags=0x1014, lprect=0x219c8c0, wstr=0x4973fe8, count=0x7, lpDx=0x0) [/home/alh/wine/dlls/winex11.drv/xrender.c:1255] in winex11 (0x0219c628) 4 0x672a539d X11DRV_ExtTextOut+0x5d(physDev=0x1322c0, x=0x0, y=0x9, flags=0x1014, lprect=0x219c8c0, wstr=0x4973fe8, count=0x7, lpDx=0x0) [/home/alh/wine/dlls/winex11.drv/text.c:55] in winex11 (0x0219c6e8) 5 0x75d98e62 ExtTextOutW+0xac2(hdc=0x30c, x=0x0, y=0x9, flags=0x1014, lprect=0x219d2fc, str=0x219ca0c, count=0x7, lpDx=0x0) [/home/alh/wine/dlls/gdi32/font.c:2225] in gdi32 (0x0219c908) 6 0x75ea5a19 DrawTextExW+0xaa9(hdc=0x30c, str=0x4954198, i_count=0xffffffff, rect=0x219d2fc, flags=0x50, dtp=0x219d2a0) [/home/alh/wine/dlls/user32/text.c:957] in user32 (0x0219d268) 7 0x75ea693f DrawTextW+0x6f(hdc=0x30c, str=0x4954198, count=0xffffffff, rect=0x219d2fc, flags=0x50) [/home/alh/wine/dlls/user32/text.c:1090] in user32 (0x0219d2b8) 8 0x75e9cf74 STATIC_PaintTextfn+0x84(hwnd=0x10078, hdc=0x30c, style=0x0) [/home/alh/wine/dlls/user32/static.c:744] in user32 (0x0219d318) If you need any more information , let me know. Best Regards Alistair Leslie-Hughes

2 2

re: shell32: Check if token references the current user
by Dan Kegel 09 Jan '08

09 Jan '08

Ge is looking for feedback on this patch, could somebody familiar with the innards of SHGetFolderPath() comment? http://bugs.winehq.org/show_bug.cgi?id=10905#c6 / http://www.winehq.org/pipermail/wine-patches/2007-December/048437.html Thanks, Dan

2 1

re: Spelling fixes - round 6
by Dan Kegel 09 Jan '08

09 Jan '08

A few issues: 1. * DPMI_xalloc - * special virtualalloc, allocates lineary monoton growing memory. + * special virtualalloc, allocates linear monoton growing memory. Um... Probably should be 'linearly'. But if you're opening the can of worms, might as well really improve it. I suspect this would be better: * DPMI_xalloc - * special virtualalloc, allocates lineary monoton growing memory. + * Try to VirtualAlloc the len bytes just past the last block we allocated + * If that's not available, try 64K beyond; if still not available, fail. 2. -/* Volume functions derived from Alsaplayer source */ +/* Volume functions derivated from Alsaplayer source */ What? What's wrong with "derived"? "Derivated" isn't even a word?! 3. -# include <unistd.h> +#include <unistd.h> That's not a spelling fix, and you would have to fix a whole lot of those. Best leave alone. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Re: Spelling fixes round 6 - resend - don't apply first patch
by Francois Gouget 09 Jan '08

09 Jan '08

#ifdef HAVE_UNISTD_H -# include <unistd.h> +#include <unistd.h> #endif #include <stdarg.h> #include <stdio.h> I think this chunk should not be applied because: * as pointed out before, it's not a spelling fix * it's perfectly valid to have a space there * the indentation makes the scope of the #ifdef clearer. So removing it makes the code less readable -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ You can have my guns when you pry them from my kids cold, dead hands.

3 2

Re: [PATCH] wineboot: fix installation of SFP protected files
by Dmitry Timoshkov 09 Jan '08

09 Jan '08

"Andrey Turkin" <andrey.turkin(a)gmail.com> wrote: > + dllcache_wildcard = HeapAlloc(GetProcessHeap(), 0, strlenW( dllcache )*sizeof(WCHAR) * sizeof(wildcardW)); Aren't there too much of multiplications? -- Dmitry.

2 1

Re: gdi32: Fix the regression caused by the scaling font metrics patch
by Alexandre Julliard 09 Jan '08

09 Jan '08

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > Changelog: > gdi32: Fix the regression caused by the scaling font metrics patch. This breaks the tests: ../../../tools/runtest -q -P wine -M riched20.dll -T ../../.. -p riched20_test.exe.so editor.c && touch editor.ok editor.c:309: Test failed: 0 == 0 editor.c:317: Test failed: 0 == 0 editor.c:865: Test failed: EM_SCROLL page down didn't scroll by a small positive number of lines (r == 0x00010000) editor.c:869: Test failed: EM_SCROLL page down not functioning (line 0 scrolled to line 0 editor.c:876: Test failed: EM_SCROLL page up didn't scroll by a small negative number of lines (r == 0x00010000) editor.c:879: Test failed: EM_SCROLL page up not functioning (line 0 scrolled to line 0 editor.c:888: Test failed: EM_SCROLL line down didn't scroll by one line (r == 0x00010000) editor.c:890: Test failed: EM_SCROLL line down didn't go down by 1 line (0 scrolled to 0) editor.c:899: Test failed: EM_SCROLL line up didn't scroll by one line (r == 0x00010000) editor.c:901: Test failed: EM_SCROLL line up didn't go up by 1 line (0 scrolled to 0) editor.c:865: Test failed: EM_SCROLL page down didn't scroll by a small positive number of lines (r == 0x00010000) editor.c:869: Test failed: EM_SCROLL page down not functioning (line 0 scrolled to line 0 editor.c:876: Test failed: EM_SCROLL page up didn't scroll by a small negative number of lines (r == 0x00010000) editor.c:879: Test failed: EM_SCROLL page up not functioning (line 0 scrolled to line 0 editor.c:888: Test failed: EM_SCROLL line down didn't scroll by one line (r == 0x00010000) editor.c:890: Test failed: EM_SCROLL line down didn't go down by 1 line (0 scrolled to 0) editor.c:899: Test failed: EM_SCROLL line up didn't scroll by one line (r == 0x00010000) editor.c:901: Test failed: EM_SCROLL line up didn't go up by 1 line (0 scrolled to 0) make[2]: *** [editor.ok] Error 18 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: server/token.c -- -Wtype-limits changes
by Alexandre Julliard 09 Jan '08

09 Jan '08

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > diff -u -3 -p -r1.60 token.c > --- server/token.c 6 Dec 2007 14:27:53 -0000 1.60 > +++ server/token.c 7 Jan 2008 13:57:28 -0000 > @@ -515,8 +515,7 @@ struct token *token_duplicate( struct to > struct privilege *privilege; > struct group *group; > > - if ((impersonation_level < SecurityAnonymous) || > - (impersonation_level > SecurityDelegation)) > + if (impersonation_level > SecurityDelegation) There's no guarantee that the enum is an unsigned type. -- Alexandre Julliard julliard(a)winehq.org

1 0

← Newer
1
...
17
18
19
20
21
22
23
...
29
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel January 2008