wine-devel January 2008

wine-devel@winehq.org

126 participants
290 discussions

system tray icon regression
by Lei Zhang 25 Jan '08

25 Jan '08

Hi, With today's wine-git, tray icons no longer work. There's a spot in the system tray where the icon should be, but nothing is displayed there and I can't interact with it. This occurred on both KDE and Gnome. I found this with Picasa, but you can also see the problem with this sample program: http://bugs.winehq.org/attachment.cgi?id=9725 - Lei

1 1

Re: dlls/d3d9/tests/visual.c -- address five compiler warnings (RESEND)
by Alexandre Julliard 25 Jan '08

25 Jan '08

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > @@ -4348,12 +4349,12 @@ static void vshader_version_varying_test > "vs_3_0 returned color 0x%08x, expected 0x00203366\n", color); > color = getPixelColor(device, 160, 360); > ok((color & 0x00ff0000) >= 0x003c0000 && (color & 0x00ff0000) <= 0x004e0000 && > - (color & 0x0000ff00) >= 0x00000000 && (color & 0x0000ff00) <= 0x00000000 && > + (color & 0x0000ff00) <= 0x00000000 && > (color & 0x000000ff) >= 0x00000066 && (color & 0x000000ff) <= 0x00210068, > "vs_1_1 returned color 0x%08x, expected 0x00808080\n", color); > color = getPixelColor(device, 480, 360); > ok((color & 0x00ff0000) >= 0x003c0000 && (color & 0x00ff0000) <= 0x004e0000 && > - (color & 0x0000ff00) >= 0x00000000 && (color & 0x0000ff00) <= 0x00000000 && > + (color & 0x0000ff00) <= 0x00000000 && > (color & 0x000000ff) >= 0x00000066 && (color & 0x000000ff) <= 0x00210068, > "vs_2_0 returned color 0x%08x, expected 0x00000000\n", color); These tests don't make much sense, with or without your fix, plus the error messages don't match the tests. This needs more work. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: winex11.drv: Remove an incorrect FIXME
by Alexandre Julliard 25 Jan '08

25 Jan '08

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > diff --git a/dlls/winex11.drv/x11drv_main.c b/dlls/winex11.drv/x11drv_main.c > index f2bf12c..948c58c 100644 > --- a/dlls/winex11.drv/x11drv_main.c > +++ b/dlls/winex11.drv/x11drv_main.c > @@ -498,10 +498,7 @@ static BOOL process_attach(void) > break; > > case 15: > - /* Out tests suggest that windows does not support 15 bpp color depth. > - * X11 does, what should we do with these situations? > - */ > - FIXME("The X server is running at 15 bpp color depth\n"); > + /* It's the same thing as 16 bpp but with different bit fields */ > screen_bpp = 15; Shouldn't screen_bpp be set to 16 then? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: msxml3: Implement IXMLDOMDocument IDispatch interface
by Alistair Leslie-Hughes 25 Jan '08

25 Jan '08

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:fnchqv$a5r$1@ger.gmane.org... > Hi, > > Fixes bug http://bugs.winehq.org/show_bug.cgi?id=11257 > Correction Fixes http://bugs.winehq.org/show_bug.cgi?id=8152 Best Regards Alistair Leslie-Hughes

1 0

Re: comctl32: Vista sends an unidentified message when destroyingdatetime and monthcal windows.
by Dmitry Timoshkov 25 Jan '08

25 Jan '08

"Reece Dunn" <msclrhd(a)googlemail.com> wrote: > When destroying datetime and monthcal controls, Vista sends a message > with the value 0x0090. This messasge is not in winuser.h of the Vista > SDK. > +#define WM_UNKNOWN_VISTA1 0x0090 IMO just adding { 0x0090, sent|optional }, /* Vista */ is clear enough, WM_UNKNOWN_VISTA1 clutters the code. -- Dmitry.

2 1

re: system tray icon regression
by Dan Kegel 25 Jan '08

25 Jan '08

Lei wrote: > With today's wine-git, tray icons no longer work ... > http://bugs.winehq.org/attachment.cgi?id=9725 What bug number is that associated with, btw?

2 1

Re: user32: make the edit tests pass on Vista.
by Reece Dunn 24 Jan '08

24 Jan '08

On 24/01/2008, Reece Dunn <msclrhd(a)googlemail.com> wrote: > This adds a return code value returned by Vista in one of the test > cases to fix the uxtheme tests. > > - Reece Ignore this (sent the wrong patch). - Reece

1 0

re: Assorted spelling fixes
by Dan Kegel 24 Jan '08

24 Jan '08

Austin wrote: >- /* centred vertically and in the right side of the password edit control */ >+ /* centered vertically and in the right side of the password edit control */ I never thought about it before, but "centred" is perfectly fine English, at least in England. Guess I need to add that to stop.txt.

4 4

Re: [PATCH] fixed potential double free
by Alexandre Julliard 24 Jan '08

24 Jan '08

Marcus Meissner <marcus(a)jet.franken.de> writes: > Coverity spotted that set_window_pos() could call > free_region() on the same pointer twice. > > (CID 671 and 672) > > Check that they are different before freeing them twice. This can't happen, Coverity is confused. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well
by Jason Green 24 Jan '08

24 Jan '08

On Jan 22, 2008 4:00 PM, Eric Pouech <eric.pouech(a)orange.fr> wrote: > Jason Green a écrit : > > Re-responses from Eric van Beurden: > > > > > >> hmm I still don't get how, in a generic way symbols could overlap > >> the only think I could come up with if when static functions get > >> automatically inlined by the compiler, but that's rather a different > >> story (as I'd suspect the inlined function to be a single memory range > >> within a container => and in that case returning the shortest matching > >> symbol should be fine is there an existing exe/pdb file available for > >> further testings > >> > > > > > > in testing with one of our projects, i was seeing symbols lookups fail > > 85-90% of the time with the initial versions of dbghelp. The PDB > > files that were being used were generated along with the release build > > of the project (it was a C++ project as well). On further > > investigation i found that the lookups were failing because many > > symbol addresses and ranges were overlapping. This seemed to occur on > > even unrelated objects and symbols. I would suspect it was the result > > of the optimizations the compiler performed. > > > > I was able to generate PDBs that exhibited this behaviour with every > > test app i built under Visual Studio (v7.1 and 8.0Express); even apps > > that were only 25 lines long. Since it was very repeatable and the > > project in question would always be using PDBs generated from > > optimized release builds i decided to change the symbol lookup method > > to take the range into account and to be able to store a sublist of > > all symbols whose addresses fall into the same range (15-25% of the > > lookups still failed with just the range addition). > > > I'm still not convinced that the fix proposed is the correct one. Do you > have one of those examples handy so that I can have a look on it (src > file + .exe + .pdb) ? that would be great > TIA Re-re-responses from Eric van Beurden. I'll send the sample app to you off-list (and anyone else who wants a copy, just email me directly).: I tracked down one of my sample apps that showed the overlapping symbols issue in its PDB file. Many of the symbols in it are either coincident or overlapping. In some cases the overlap occurs between a C++ decorated name and its undecorated counterpart, but in several cases the overlapping symbols are unrelated. For some symbols it could be possible that their sizes are being read incorrectly from the PDB. The original symbol lookup method used a binary search on a symbol list that was sorted by starting address. The issue was that during the search it was skipping over the correct symbol because its starting address was the same as a previous symbol's address. This sent the search in the wrong direction after that and the lookup would fail. There was no fallback for handling the case of the symbol being coincident with another or the symbol being within the address space of another symbol. The attached archive contains 4 files: - 'emptyTest.exe': the optimized release build executable linked to 'emptyTest.pdb'. This should crash. - 'emptyTest.pdb': the PDB file - 'main.cpp': the source file for the test app. Some of the code is unused as the app has morphed over time. - 'emptyTest.vcproj': the VC++7.1 project file for the test app

3 5

← Newer
1
...
4
5
6
7
8
9
10
...
29
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel January 2008