wine-devel January 2008

wine-devel@winehq.org

126 participants
290 discussions

Re: msxml3: Implement ownerDocument
by Alistair Leslie-Hughes 24 Jan '08

24 Jan '08

Dont apply this patch. "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:fn6308$1gf$1@ger.gmane.org... > Hi, > > Changelog: > msxml3: Implement ownerDocument > > Best Regards > Alistair Leslie-Hughes > -------------------------------------------------------------------------------- > From 422440f49888d555c6031e3e40cafda0523c6ad8 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Wed, 23 Jan 2008 11:07:59 +1100 > Subject: [PATCH] Implement ownerDocument > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/msxml3/node.c | 22 ++++++++++++++++++++-- > dlls/msxml3/tests/domdoc.c | 23 +++++++++++++++++++++-- > 2 files changed, 41 insertions(+), 4 deletions(-) > > diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c > index 9d43c09..bc7a2a0 100644 > --- a/dlls/msxml3/node.c > +++ b/dlls/msxml3/node.c > @@ -602,8 +602,26 @@ static HRESULT WINAPI xmlnode_get_ownerDocument( > IXMLDOMNode *iface, > IXMLDOMDocument** DOMDocument) > { > - FIXME("\n"); > - return E_NOTIMPL; > + HRESULT hr = S_OK; > + xmlnode *This = impl_from_IXMLDOMNode( iface ); > + TRACE("\n"); > + > + if(!DOMDocument) > + return E_INVALIDARG; > + > + *DOMDocument = NULL; > + > + switch( This->node->type ) > + { > + case XML_DOCUMENT_NODE: > + hr = S_FALSE; > + break; > + default: > + *DOMDocument = (IXMLDOMDocument*)create_basic_node( > (xmlNodePtr)This->node->doc, NULL ); > > + break; > + } > + > + return hr; > } > > static HRESULT WINAPI xmlnode_cloneNode( > diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c > index 4507d08..8802053 100644 > --- a/dlls/msxml3/tests/domdoc.c > +++ b/dlls/msxml3/tests/domdoc.c > @@ -687,10 +687,9 @@ static void test_domnode( void ) > { > owner = NULL; > r = IXMLDOMNode_get_ownerDocument( element, &owner ); > - todo_wine { > ok( r == S_OK, "get_ownerDocument return code\n"); > - } > ok( owner != doc, "get_ownerDocument return\n"); > + IXMLDOMDocument_Release(owner); > > type = NODE_INVALID; > r = IXMLDOMNode_get_nodeType( element, &type); > @@ -1869,6 +1868,7 @@ static void test_cloneNode(void ) > static void test_xmlTypes(void) > { > IXMLDOMDocument *doc = NULL; > + IXMLDOMDocument *docOwner = NULL; > IXMLDOMElement *pRoot; > HRESULT hr; > IXMLDOMComment *pComment; > @@ -1923,6 +1923,25 @@ static void test_xmlTypes(void) > ok(hr == S_OK, "ret %08x\n", hr ); > ok( !lstrcmpW( str, _bstr_("document") ), "incorrect nodeTypeString > string\n"); > SysFreeString(str); > + > + /* test ownerDocument */ > + hr = IXMLDOMDocument_get_ownerDocument(doc, NULL); > + ok(hr == E_INVALIDARG, "ret %08x\n", hr ); > + > + hr = IXMLDOMDocument_get_ownerDocument(doc, &docOwner); > + ok(hr == S_FALSE, "ret %08x\n", hr ); > + ok(docOwner == NULL, "ownerDocument return a value\n"); > + if(docOwner != NULL) > + { > + str = NULL; > + hr = IXMLDOMDocument_get_nodeName( docOwner, &str ); > + ok ( hr == S_OK, "get_nodeName wrong code\n"); > + ok ( str != NULL, "str is null\n"); > + ok( !lstrcmpW( str, szDocument ), "incorrect nodeName\n"); > + SysFreeString( str ); > + > + IXMLDOMDocument_Release(docOwner); > + } > > /* test implementation */ > hr = IXMLDOMDocument_get_implementation(doc, NULL); > -- > 1.5.3.7 > > -------------------------------------------------------------------------------- > >

1 0

help with typelib support
by Alistair Leslie-Hughes 24 Jan '08

24 Jan '08

Hi, This msxml bug requires the TYPELIB resource to be added. http://bugs.winehq.org/show_bug.cgi?id=11257 I modified the followng file as follows. Makefile.in IDL_TLB_SRCS = msxml3_v1.idl msxml3_v1.idl (new File, with a single line) #include "msxml2.idl" version.rc 1 TYPELIB LOADONCALL DISCARDABLE msxml3_v1.tlb The issue I am seing is the msxml3_v1.tlb is not being created. Output. ../../tools/widl/widl -I. -I. -I../../include -I../../include -I/usr/include/libxml2 -I/usr/include/libxml2 -D__WINESRC__ -DCOM_NO_WINDOWS_H -t -T msxml3_v1.tlb msxml3_v1.idl ../../tools/wrc/wrc --nostdinc -I. -I. -I../../include -I../../include -I/usr/include/libxml2 -I/usr/include/libxml2 -D__WINESRC__ -DCOM_NO_WINDOWS_H -foversion.res version.rc version.rc:26:47: Error: Cannot open file msxml3_v1.tlb Any ideas on what is wrong? Best Regards Alistair Leslie-Hughes

3 4

user32: listbox failures
by Reece Dunn 24 Jan '08

24 Jan '08

Running the listbox tests from dlls/user32/tests, I don't get any test failures on Vista. Can anyone else confirm this? Also, the LB_DIR failures on http://test.winehq.org/ are due to it looking for files in dlls/user32/tests as part of its test run. Since these are not available when running it as part of the test suite that generates those test results - or if you are running it as as standalone in another directory (e.g. building it on one machine, then running it on another) - the tests are failing. My thoughts on this is to create some dummy data used by the tests, then cleaning this up after the tests are run. This will all be self-contained in listbox.c. Does anyone have a better idea? If not, I'll look into this and provide a patch. - Reece

1 0

[msi/tests] Install tests on win9x and NT4
by Paul Vriens 23 Jan '08

23 Jan '08

Hi, Currently the install test fail/crash on at least win95 and NT4. The main reason I found was that pMsiQueryComponentStateA and pMsiSourceListGetInfoA are not guarded. Does it makes sense to guard every instance of these calls and just continue: if (pMsiSourceListGetInfoA) { call test outcome } or should we skip the whole subtest when the function is not available. Guarding each single item requires 28 of these if-statements or is there an other alternative? (like creating a function/macro to deal with this) Just guarding the functions makes the tests not crash but they still fail (that is another issue of course). -- Cheers, Paul.

3 3

appdb test results queue count wrong?
by Dan Kegel 23 Jan '08

23 Jan '08

When an app maintainer is logged in to the appdb, and there are test results queued for approval, the test results queue length is wrongly reported as zero at the moment...

3 3

Re: Alexandre Julliard : winex11.drv: Fix handling of strange window sizes in CreateWindow, with tests.
by Lei Zhang 23 Jan '08

23 Jan '08

On Jan 22, 2008 4:01 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: > Module: wine > Branch: master > Commit: 390ae9cc2845fe002bc2e68c14d104d927af68b1 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=390ae9cc2845fe002bc2e68c1… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Tue Jan 22 10:16:19 2008 +0100 > > winex11.drv: Fix handling of strange window sizes in CreateWindow, with tests. > > --- > > dlls/user32/tests/win.c | 79 +++++++++++++++++++++++++++++++++++++++++++++ > dlls/winex11.drv/window.c | 42 +++++------------------- > 2 files changed, 88 insertions(+), 33 deletions(-) > > diff --git a/dlls/user32/tests/win.c b/dlls/user32/tests/win.c > index 49fe766..d0a9673 100644 > --- a/dlls/user32/tests/win.c > +++ b/dlls/user32/tests/win.c > @@ -3733,6 +3733,43 @@ static LRESULT CALLBACK minmax_wnd_proc(HWND hwnd, UINT msg, WPARAM wp, LPARAM l > return 1; > } > > +static int expected_cx, expected_cy; > +static RECT expected_rect; > + > +static LRESULT CALLBACK winsizes_wnd_proc(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp) > +{ > + switch(msg) > + { > + case WM_GETMINMAXINFO: > + { > + RECT rect; > + GetWindowRect( hwnd, &rect ); > + ok( !rect.left && !rect.top && !rect.right && !rect.bottom, > + "wrong rect %d,%d-%d,%d\n", rect.left, rect.top, rect.right, rect.bottom ); > + return DefWindowProc(hwnd, msg, wp, lp); > + } > + case WM_NCCREATE: > + case WM_CREATE: > + { > + CREATESTRUCTA *cs = (CREATESTRUCTA *)lp; > + RECT rect; > + GetWindowRect( hwnd, &rect ); > + trace( "hwnd %p msg %x size %dx%d rect %d,%d-%d,%d\n", > + hwnd, msg, cs->cx, cs->cy, rect.left, rect.top, rect.right, rect.bottom ); > + ok( cs->cx == expected_cx, "wrong x size %d/%d\n", cs->cx, expected_cx ); > + ok( cs->cy == expected_cy, "wrong y size %d/%d\n", cs->cy, expected_cy ); > + ok( rect.right - rect.left == expected_rect.right - expected_rect.left && > + rect.bottom - rect.top == expected_rect.bottom - expected_rect.top, > + "wrong rect %d,%d-%d,%d / %d,%d-%d,%d\n", > + rect.left, rect.top, rect.right, rect.bottom, > + expected_rect.left, expected_rect.top, expected_rect.right, expected_rect.bottom ); > + return DefWindowProc(hwnd, msg, wp, lp); > + } > + default: > + return DefWindowProc(hwnd, msg, wp, lp); > + } > +} > + > static void test_CreateWindow(void) > { > WNDCLASS cls; > @@ -3986,11 +4023,53 @@ static void test_CreateWindow(void) > ok(EqualRect(&rc, &rc_minmax), "rects don't match: (%d,%d-%d,%d) and (%d,%d-%d,%d)\n", > rc.left, rc.top, rc.right, rc.bottom, > rc_minmax.left, rc_minmax.top, rc_minmax.right, rc_minmax.bottom); > + DestroyWindow(hwnd); > + > + cls.lpfnWndProc = winsizes_wnd_proc; > + cls.lpszClassName = "Sizes_WndClass"; > + RegisterClass(&cls); > + > + expected_cx = expected_cy = 200000; > + SetRect( &expected_rect, 0, 0, 200000, 200000 ); > + hwnd = CreateWindowExA(0, "Sizes_WndClass", NULL, WS_CHILD, 300000, 300000, 200000, 200000, parent, 0, 0, NULL); > + ok( hwnd != 0, "creation failed err %u\n", GetLastError()); > + GetClientRect( hwnd, &rc ); > + ok( rc.right == 200000, "invalid rect right %u\n", rc.right ); > + ok( rc.bottom == 200000, "invalid rect bottom %u\n", rc.bottom ); > + DestroyWindow(hwnd); > + > + expected_cx = expected_cy = -10; > + SetRect( &expected_rect, 0, 0, 0, 0 ); > + hwnd = CreateWindowExA(0, "Sizes_WndClass", NULL, WS_CHILD, -20, -20, -10, -10, parent, 0, 0, NULL); > + ok( hwnd != 0, "creation failed err %u\n", GetLastError()); > + GetClientRect( hwnd, &rc ); > + ok( rc.right == 0, "invalid rect right %u\n", rc.right ); > + ok( rc.bottom == 0, "invalid rect bottom %u\n", rc.bottom ); > + DestroyWindow(hwnd); > > + expected_cx = expected_cy = -200000; > + SetRect( &expected_rect, 0, 0, 0, 0 ); > + hwnd = CreateWindowExA(0, "Sizes_WndClass", NULL, WS_CHILD, -300000, -300000, -200000, -200000, parent, 0, 0, NULL); > + ok( hwnd != 0, "creation failed err %u\n", GetLastError()); > + GetClientRect( hwnd, &rc ); > + ok( rc.right == 0, "invalid rect right %u\n", rc.right ); > + ok( rc.bottom == 0, "invalid rect bottom %u\n", rc.bottom ); > DestroyWindow(hwnd); > + > + /* top level window */ > + expected_cx = expected_cy = 200000; > + SetRect( &expected_rect, 0, 0, GetSystemMetrics(SM_CXMAXTRACK), GetSystemMetrics(SM_CYMAXTRACK) ); > + hwnd = CreateWindowExA(0, "Sizes_WndClass", NULL, WS_OVERLAPPEDWINDOW, 300000, 300000, 200000, 200000, 0, 0, 0, NULL); > + ok( hwnd != 0, "creation failed err %u\n", GetLastError()); > + GetClientRect( hwnd, &rc ); > + ok( rc.right <= expected_cx, "invalid rect right %u\n", rc.right ); > + ok( rc.bottom <= expected_cy, "invalid rect bottom %u\n", rc.bottom ); > + DestroyWindow(hwnd); > + > DestroyWindow(parent); > > UnregisterClass("MinMax_WndClass", GetModuleHandle(0)); > + UnregisterClass("Sizes_WndClass", GetModuleHandle(0)); > > #undef expect_menu > #undef expect_style > diff --git a/dlls/winex11.drv/window.c b/dlls/winex11.drv/window.c > index 84209b7..3f65602 100644 > --- a/dlls/winex11.drv/window.c > +++ b/dlls/winex11.drv/window.c > @@ -1296,37 +1296,13 @@ BOOL X11DRV_CreateWindow( HWND hwnd, CREATESTRUCTA *cs, BOOL unicode ) > CBT_CREATEWNDA cbtc; > CREATESTRUCTA cbcs; > BOOL ret = FALSE; > + INT cx = cs->cx, cy = cs->cy; > > if (!(data = alloc_win_data( display, hwnd ))) return FALSE; > > - if (cs->cx > 65535) > - { > - ERR( "invalid window width %d\n", cs->cx ); > - cs->cx = 65535; > - } > - if (cs->cy > 65535) > - { > - ERR( "invalid window height %d\n", cs->cy ); > - cs->cy = 65535; > - } > - if (cs->cx < 0) > - { > - ERR( "invalid window width %d\n", cs->cx ); > - cs->cx = 0; > - } > - if (cs->cy < 0) > - { > - ERR( "invalid window height %d\n", cs->cy ); > - cs->cy = 0; > - } > - > if (hwnd == GetDesktopWindow()) get_desktop_xwin( display, data ); > else > { > - /* initialize the dimensions before sending WM_GETMINMAXINFO */ > - SetRect( &rect, cs->x, cs->y, cs->x + cs->cx, cs->y + cs->cy ); > - X11DRV_SetWindowPos( hwnd, 0, &rect, &rect, SWP_NOZORDER | SWP_NOACTIVATE, NULL ); > - > /* create an X window if it's a top level window */ > if (GetAncestor( hwnd, GA_PARENT ) == GetDesktopWindow()) > { > @@ -1360,16 +1336,16 @@ BOOL X11DRV_CreateWindow( HWND hwnd, CREATESTRUCTA *cs, BOOL unicode ) > POINT maxSize, maxPos, minTrack, maxTrack; > > WINPOS_GetMinMaxInfo( hwnd, &maxSize, &maxPos, &minTrack, &maxTrack); > - if (maxTrack.x < cs->cx) cs->cx = maxTrack.x; > - if (maxTrack.y < cs->cy) cs->cy = maxTrack.y; > - if (cs->cx < 0) cs->cx = 0; > - if (cs->cy < 0) cs->cy = 0; > - > - SetRect( &rect, cs->x, cs->y, cs->x + cs->cx, cs->y + cs->cy ); > - if (!X11DRV_SetWindowPos( hwnd, 0, &rect, &rect, SWP_NOZORDER | SWP_NOACTIVATE, NULL )) > - return FALSE; > + if (maxTrack.x < cx) cx = maxTrack.x; > + if (maxTrack.y < cy) cy = maxTrack.y; > } > > + if (cx < 0) cx = 0; > + if (cy < 0) cy = 0; > + SetRect( &rect, cs->x, cs->y, cs->x + cx, cs->y + cy ); > + if (!X11DRV_SetWindowPos( hwnd, 0, &rect, &rect, SWP_NOZORDER | SWP_NOACTIVATE, NULL )) > + return FALSE; > + > /* send WM_NCCREATE */ > TRACE( "hwnd %p cs %d,%d %dx%d\n", hwnd, cs->x, cs->y, cs->cx, cs->cy ); > if (unicode) > > > > I've having trouble on my dual screen (twinview) setup with this patch. With a fresh ~/.wine directory, I ran notepad or regedit. The app starts on the left monitor. When I move the window to the right monitor, the window is no longer being redrawn.

3 2

Re: gdi32: Fix spec file to export the right symbols for GetGlyphOutline
by Dmitry Timoshkov 23 Jan '08

23 Jan '08

"Kai Blin" <kai.blin(a)gmail.com> wrote: > --- a/dlls/gdi32/gdi32.spec > +++ b/dlls/gdi32/gdi32.spec > @@ -282,7 +282,6 @@ > @ stdcall GetFontUnicodeRanges(ptr ptr) > @ stdcall GetGlyphIndicesA(long ptr long ptr long) > @ stdcall GetGlyphIndicesW(long ptr long ptr long) > -@ stub GetGlyphOutline > @ stdcall GetGlyphOutlineA(long long long ptr long ptr ptr) > @ stdcall GetGlyphOutlineW(long long long ptr long ptr ptr) > @ stub GetGlyphOutlineWow This patch is not correct. gdi32 does export GetGlyphOutline at least in XP. It just points to GetGlyphOutlineA. -- Dmitry.

2 1

Problem with winelib
by Nagarjuna Bandi 23 Jan '08

23 Jan '08

Dear Wine Developers Team, I am using the wine for porting windows applications under linux. This is a very powerful tool for doing this job thank you very much for providing us a such tool. Here i am getting problem with winelib when i trying to build the notepad application with the given guidelines in winelib user guide i had made the changes to Makefile you are specifying but i got another error msg like [nagarjunab@ibi212 notepad2]$ vim Makefile [nagarjunab@ibi212 notepad2]$ make wrc -I. -forsrc.res rsrc.rc winegcc -mwindows -mno-cygwin -o notepad2.exe.so dialog.o main.o rsrc.res -lodbc32 -lole32 -loleaut32 -lwinspool -luuid dialog.o(.text+0x1a5): In function `DIALOG_StringMsgBox': : undefined reference to `wnsprintfW' collect2: ld returned 1 exit status winegcc: gcc failed. make: *** [notepad2.exe.so] Error 2 This is the error i am getting so please let me know what is the problem and what i have to do for avoiding this problem. I am expecting a fast response from you. Thanks in advance. --------------------------------- Regards, Nagarjuna Bandi , Infobrain Technologies Pvt. Ltd. | My Home Sarovar Plaza | Hyderabad | India. --------------------------------- Explore your hobbies and interests. Click here to begin.

4 4

Re: [dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well
by Eric Pouech 22 Jan '08

22 Jan '08

Jason Green a écrit : > ------------------------------------------------------------------------ > > From 14d91ebd5974c8fc02f8b83d53e8eff0df7ad76d Mon Sep 17 00:00:00 2001 > From: Jason Green <jason(a)jave01.(none)> > Date: Thu, 17 Jan 2008 16:41:11 -0500 > Subject: [PATCH] Rewrite much of the symbol lookup method to work with Optimized PDB files as well. > Also, improves a number of TRACEs, and wraps strings in the debugstr() functions. > what's the rationale of optimized pdb ? the patch is already big enough not to mix code evolution with stuffing new trace:s all over the place A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 3

Suggestion to the list maintainer
by kubrick＠fgv6.net 22 Jan '08

22 Jan '08

Hello. I have many subscriptions to different mailing list with my email-address and I'd appreciate a lot to be able to identify a message from this mailing list quickly by reading it's subject. Could you please add a subject prefix like [WINE-DEVEL] in the mailman preferences ? It's very easy to do, so maybe there is a good reason why you haven't done it yet... Thanks. François.

8 15

← Newer
1
...
6
7
8
9
10
11
12
...
29
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel January 2008