June 2025 - wine-gitlab

[PATCH v11 0/6] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) 18 Jun '25

18 Jun '25

In CopyFileEx, and DeleteFile functions, by default, the file name and path are limited to MAX_PATH characters. To extend this limit to 32,767 wide characters, need prepend "\\\\?\\" to the path. -- v11: kernelbase: Limit the maximum path length for DeleteFile. kernelbase: Fix DeleteFileA doesn't support long path. kernelbase: Limit the maximum path length for filesystem. ntdll: Check if long path aware is enabled. kernel32/tests: Add tests for DeleteFile kernel32/tests: Add tests for maximum path length limitation. https://gitlab.winehq.org/wine/wine/-/merge_requests/7540

2 6

Re: [PATCH v4 0/6] MR8326: ntdll: Implement RtlActivateActivationContextUnsafeFast().
by Nikolay Sivov (＠nsivov) 18 Jun '25

18 Jun '25

Nikolay Sivov (@nsivov) commented about dlls/ntdll/actctx.c: > +/****************************************************************** > + * RtlDeactivateActivationContextUnsafeFast (NTDLL.@) > + * > + * FIXME: function prototype might be wrong > + */ > +VOID FASTCALL RtlDeactivateActivationContextUnsafeFast( RTL_CALLER_ALLOCATED_ACTIVATION_CONTEXT_STACK_FRAME_EXTENDED *frame_extended ) > +{ > + ACTIVATION_CONTEXT_STACK *actctx_stack = NtCurrentTeb()->ActivationContextStackPointer; > + ACTIVATION_CONTEXT *actctx; > + > + TRACE( "%p\n", frame_extended ); > + > + actctx = actctx_stack->ActiveFrame->ActivationContext; > + actctx_stack->ActiveFrame = frame_extended->Frame.Previous; > + RtlReleaseActivationContext( actctx ); > +} Should we check anything here? For example ActiveFrame could be null or it could be that ActiveFrame != &frame_extended->Frame. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8326#note_107024

1 0

Re: [PATCH v4 0/6] MR8326: ntdll: Implement RtlActivateActivationContextUnsafeFast().
by Nikolay Sivov (＠nsivov) 18 Jun '25

18 Jun '25

Nikolay Sivov (@nsivov) commented about dlls/kernelbase/loader.c: > */ > BOOL WINAPI DECLSPEC_HOTPATCH GetCurrentActCtx( HANDLE *pcontext ) > { > - return set_ntstatus( RtlGetActiveActivationContext( pcontext )); > + struct _ACTIVATION_CONTEXT *actctx; > + NTSTATUS status; > + > + status = RtlGetActiveActivationContext( &actctx ); > + if (status == STATUS_SUCCESS) > + *pcontext = actctx; > + return set_ntstatus( status ); > } I think you can just cast to "struct _ACTIVATION_CONTEXT *" here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8326#note_107021

1 0

[PATCH 0/5] MR8340: widl: Add rows for propget methods.
by Hans Leidekker (＠hans) 18 Jun '25

18 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8340

3 13

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) 18 Jun '25

18 Jun '25

On Wed Jun 18 08:29:18 2025 +0000, Nikolay Sivov wrote: > This will change behavior for all the tests. We can create this file > dynamically as an external manifest, then restart as a child process. Right. That would be better. Let's do that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106999

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Nikolay Sivov (＠nsivov) 18 Jun '25

18 Jun '25

On Wed Jun 18 08:27:27 2025 +0000, Zhiyi Zhang wrote: > I see. In that case, you can leave it and keep the longPathAware > manifest in the kernel32 test resource. This will change behavior for all the tests. We can create this file dynamically as an external manifest, then restart as a child process. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106998

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) 18 Jun '25

18 Jun '25

On Wed Jun 18 08:25:18 2025 +0000, Yongjie Yao wrote: > When testing on windows 11, handle=CreateActCtxW() -> > ActivateActCtx(handle) -> QueryActCtxSettingsW(handle), the value of the > longPathAware is true, but CopyFileExA still can't support long path. > When I create a file with kernel32_test.exe.manifest as filename and > test again, CopyFileExA can support long path. So I guess it is just > checked at process startup. I see. In that case, you can leave it and keep the longPathAware manifest in the kernel32 test resource. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106997

1 0

[PATCH 0/1] MR8359: include: Add APP_LOCAL_DEVICE_ID definition.
by Rémi Bernon (＠rbernon) 18 Jun '25

18 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8359

2 1

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) 18 Jun '25

18 Jun '25

On Mon Jun 16 10:56:00 2025 +0000, Zhiyi Zhang wrote: > Please test if activating the longPathAware manifest dynamically sets > IsLongPathAwareProcess, or if it is just checked at process startup. > MSDN says the LongPathsEnabled registry value is cached. However, it > doesn't say if the manifest is cached. This could be a local test. When testing on windows 11, handle=CreateActCtxW() -> ActivateActCtx(handle) -> QueryActCtxSettingsW(handle), the value of the longPathAware is true, but CopyFileExA still can't support long path. When I create a file with kernel32_test.exe.manifest and test again, CopyFileExA can support long path. So I guess it is just checked at process startup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106996

1 0

[PATCH v3 0/6] MR8326: ntdll: Implement RtlActivateActivationContextUnsafeFast().
by Zhiyi Zhang (＠zhiyi) 18 Jun '25

18 Jun '25

For React Native. -- v3: kernel32/tests: Add tests for RtlActivateActivationContextUnsafe() and RtlDeactivateActivationContextUnsafeFast(). ntdll: Implement RtlDeactivateActivationContextUnsafeFast(). ntdll: Implement RtlActivateActivationContextUnsafeFast(). ntdll: Set and check 0x8 flag for activation context stack frames. kernel32/tests: Add tests for normal activation context stack frame flags. ntdll: Use explicit ACTIVATION_CONTEXT type instead of HANDLE. https://gitlab.winehq.org/wine/wine/-/merge_requests/8326

2 7

2025

2024

2023

2022

wine-gitlab June 2025