June 2025 - wine-gitlab

[PATCH 0/1] MR8350: crypt32: Handle missing attributes in CDecodeSignedMsg_GetParam.
by Yuxuan Shui (＠yshui) 18 Jun '25

18 Jun '25

* * * While investigating another problem, I found we are handling empty attributes list differently compared native. But the actual problem is this, shouldn't `CRYPT_SizeOfAttributes` add `sizeof(CRYPT_ATTRIBUTES)` to `size`? Basically we return `size == 0` when the attributes list is empty, so the caller allocates zero bytes and call `GetParam` again, and we write out-of-bound trying to `out->cAttrs = in->cAttrs` in `CRYPT_ConstructAttributes`. (Of course with this MR this problem no longer show up, but the question still stands.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8350

4 3

[PATCH 0/1] MR8128: winex11.drv: Reconfigure window even if the new rectangle equals to the old one.
by Zhiyi Zhang (＠zhiyi) 18 Jun '25

18 Jun '25

CW* masks in window_set_config() are from comparing against the old rect from data->pending_state.rect, not the actual X11 window rectangle. So it's still possible that after removing __NET_WM_STATE_FULLSCREEN, WM moves the window behind Wine's back. Then window_set_config() calculates CW* masks and calls XReconfigureWMWindow(), assuming the old rect is still the actual X11 window rect. As the result, some rectangle updates might be missed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8128

3 5

[PATCH 0/6] MR8357: win32u: Allocate GL drawables on behalf of the drivers.
by Rémi Bernon (＠rbernon) 18 Jun '25

18 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8357

2 6

Re: [PATCH v2 0/1] MR8316: shell32/tests: Add missing double null termination in shlfileop.
by Rémi Bernon (＠rbernon) 18 Jun '25

18 Jun '25

This broke the tests on windows: https://test.winehq.org/data/patterns.html#shell32:shlfileop -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8316#note_106983

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) 18 Jun '25

18 Jun '25

On Wed Jun 18 05:15:37 2025 +0000, Yongjie Yao wrote: > ok. You can use the "Resolve thread" button. You don't need to reply ok. Replying ok to every comment creates a lot of spam. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106982

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) 18 Jun '25

18 Jun '25

On Mon Jun 16 10:56:00 2025 +0000, Zhiyi Zhang wrote: > This test doesn't belong here. Move it to test_DeleteFileW() and another patch. ok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106981

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) 18 Jun '25

18 Jun '25

On Mon Jun 16 10:55:59 2025 +0000, Zhiyi Zhang wrote: > Add a newline after variable declaration. Same at other places. ok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106980

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) 18 Jun '25

18 Jun '25

On Mon Jun 16 10:55:59 2025 +0000, Zhiyi Zhang wrote: > Let's rename it to is_reg_long_path_enabled() ok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106979

1 0

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) 18 Jun '25

18 Jun '25

On Mon Jun 16 10:55:59 2025 +0000, Zhiyi Zhang wrote: > Put this in ntdll_misc.h. ok. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_106978

1 0

[PATCH 0/1] MR8329: comctl32: Implement MSAA events for updown controls.
by Esme Povirk (＠madewokherd) 18 Jun '25

18 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8329

4 3

2025

2024

2023

2022

wine-gitlab June 2025