- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR9057: shell32 shlwapi: Call of ShellMessageBoxW works like Windows 11.
by Jinoh Kang (＠iamahuman) 25 Sep '25

25 Sep '25

On Thu Sep 25 22:36:32 2025 +0000, Matthias Zorn wrote: > I wanted to program the PickIconDlg function for WineHQ, so I developed > a program under Windows that calls my own implementation of this > function (I called it PickIconDlg2). I looked at the source code of Wine > and got the impression that the ShellMessageBoxW function is already > implemented correctly and saw that this function is also called > internally by Wine under certain circumstances. I programmed > PickIconDlg2 to also use ShellMessageBoxW and was optimistic that the > program would run well under Wine. However, when I started the program > with Wine, it only displayed a long error message. The reason for the > program crash was that ShellMessageBoxW could not be called. So I tried > to modify ShellMessageBoxW so that the program would also run with Wine. > I compiled the program with mingw-w64 and it tried to call > ShellMessageBoxW in shlwapi.dll. Hello, thanks for your reply! You built your program with MinGW, right? It seems MinGW has a problem with shlwapi. Does your program run correctly on Windows when built *with* MinGW? Would you post a screenshot on Windows? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9057#note_116859

1 0

Re: [PATCH v2 0/1] MR9057: shell32 shlwapi: Call of ShellMessageBoxW works like Windows 11.
by Matthias Zorn (＠Matthias-Zorn.0178) 25 Sep '25

25 Sep '25

I wanted to program the PickIconDlg function for WineHQ, so I developed a program under Windows that calls my own implementation of this function (I called it PickIconDlg2). I looked at the source code of Wine and got the impression that the ShellMessageBoxW function is already implemented correctly and saw that this function is also called internally by Wine under certain circumstances. I programmed PickIconDlg2 to also use ShellMessageBoxW and was optimistic that the program would run well under Wine. However, when I started the program with Wine, it only displayed a long error message. The reason for the program crash was that ShellMessageBoxW could not be called. So I tried to modify ShellMessageBoxW so that the program would also run with Wine. I compiled the program with mingw-w64 and it tried to call ShellMessageBoxW in shlwapi.dll. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9057#note_116855

1 0

Re: [PATCH v15 0/2] MR8367: shell32: Add shield icon.
by Joel Holdsworth (＠jhol) 25 Sep '25

25 Sep '25

> And my prior patches have been asked for extensive changes, tests, etc, then someone else submits the EXACT same diff, and it passes with no commentary. You're not the first person I've heard complaining about this. It seems that patches from within Crossover have an easier time getting integrated because Julliard has an ongoing relationship with these engineers. If you're absolutely out of patience, I don't might doing some work on the graphics side, though I can't guarantee when I will have time to look at it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8367#note_116854

1 0

Re: [PATCH v15 0/2] MR8367: shell32: Add shield icon.
by James McDonnell (＠ElementalWarrior) 25 Sep '25

25 Sep '25

> 16-color VGA palette I kind of just assumed the color palette would have been handled by gimp's ico export. So when I imported it into inkscape it would be correct. Which is why everything was a raster. > These should be a vector images I did not find a svg for the 16x16 icon. Just a png. Maybe I didn't look hard enough. > prevent blurriness I had to delete most of the feathered edge and put in a hard border for this icon to look remotely nice. The 16x16 icon did not want to export to ico well, hence why the right looks slightly different than the left. It even seemed to look different between different exports. I didn't think the 256 image was even exported... Yeah I thought this MR would just have been a quick (load some obvious 'missing' icon if the other icon is not present). I barely can get myself to work on this ticket, as it is rather frustrating when you try to match examples of existing source, to be told don't do it that way, because "I don't like it that way". And my prior patches have been asked for extensive changes, tests, etc, then someone else submits the EXACT same diff, and it passes with no commentary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8367#note_116853

1 0

Re: [PATCH v15 0/2] MR8367: shell32: Add shield icon.
by Joel Holdsworth (＠jhol) 25 Sep '25

25 Sep '25

On Thu Sep 25 07:31:33 2025 +0000, James McDonnell wrote: > Please review the svg changes again. Great progress indeed. A couple of points I spotted: * The 4-bit icons need to use only colors from the [16-color VGA palette](https://en.wikipedia.org/wiki/List_of_8-bit_computer_hardware_grap…. * The 4 and 8-bit icons need to be paletted, rather than RGB. * In the 16-4 image, it looks to me that the bottom right of the shield could use some tidy up in the pixel art. It looks slightly jagged. * The 48-32, 32-32 and 16-32 icons are raster images. These should be a vector images (the 16-32 is sometimes raster in some of the other icons). It is important to keep the lines properly aligned to the pixel grid to prevent blurriness with 1px thickness. Are these included in the Tango sources? This would have been done in the original Tango source, but if the size you need is not available, you can achieve the same thing by tweaking the geometry. If you look at the other Wine icons and turn on a pixel grid in Inkscape, you will see how they have been aligned to the pixel grid. * The 48-8 and 48-4 images do not have the ids attributes set, so they won't render out. * The 256-32 image (and 48-32, 32-32 and 16-32 vector images that I am requesting), do not have the invisible rectangle element with the id set to `<rect id="icon:32-32" height="32" width="32" y="236" x="440" style="fill:none" />`, so they won't render out either. [control.svg](https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/shell32… demonstrates these points most clearly. I know this is all very pedantic, but it's necessary to achieve best results. You can understand why my [original Tango icons project](https://www.omgubuntu.co.uk/2010/05/wine-icon-facelift-on-target-for-june-looks-immeasurably-better-already) took around 14-months to complete! I thought it would be done in a weekend. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8367#note_116852

1 0

Re: [PATCH v2 0/1] MR9057: shell32 shlwapi: Call of ShellMessageBoxW works like Windows 11.
by Jinoh Kang (＠iamahuman) 25 Sep '25

25 Sep '25

Welcome to WineHQ, Matthias! Thanks for your contribution. Does this patch fix any known Windows application on Wine? Or is this a refactoring change? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9057#note_116851

1 0

[PATCH v2 0/2] MR9040: cmd: Allow DIR /Oxxx at the command line to override DIRCMD=/Oyyy set in the environment.
by Joe Souza (＠JoeS209) 25 Sep '25

25 Sep '25

Fix regression, likely caused by me, where DIR /O options entered at the command line do not override any /O options that might be set in the DIRCMD environment variable. Fix is to reset applicable sort order state whenever /O is encountered in the options list. -- v2: cmd/tests: Add DIR test for /o set in DIRCMD environment variable. https://gitlab.winehq.org/wine/wine/-/merge_requests/9040

3 6

Re: [PATCH v15 0/2] MR8367: shell32: Add shield icon.
by James McDonnell (＠ElementalWarrior) 25 Sep '25

25 Sep '25

On Tue Jul 29 18:40:30 2025 +0000, Joel Holdsworth wrote: > The > [16x16](https://git.golem.linux.it/matteobin/tango-icon-theme/src/branch/master/16x16/status/network-wireless-encrypted.png) > version will required tweaking in a pixel editor. Please review the svg changes again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8367#note_116840

1 0

[PATCH v14 0/2] MR8367: shell32: Add shield icon.
by James McDonnell (＠ElementalWarrior) 25 Sep '25

25 Sep '25

The missing shield icon was causing Affinity Photo's installer to fail to start. -- v14: shell32: Try to lookup icon shell32: Add shield icon. https://gitlab.winehq.org/wine/wine/-/merge_requests/8367

2 2

[PATCH v2 0/1] MR9033: comdlg32: Filedialog stores location when closed.
by Janne Kekkonen (＠Janne) 24 Sep '25

24 Sep '25

Filedialog location is stored when dialog is closed. When dialog is reopenned it opens to same location. Location info is stored as long as the application is running. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=40738 -- v2: comdlg32: Filedialog stores location when closed. https://gitlab.winehq.org/wine/wine/-/merge_requests/9033

2 2

2025

2024

2023

2022

wine-gitlab