> Yeah, ID2D1DrawTransform can be implemented for \*Impl object, that's true. But we still need transfrom graph. Implementing ID2D1DrawTransform for \*Impl doesn't means that it will be used automatically without doing anything else. We still need to regard it as a transform node, and add it to transfrom graph. And latter, runtime will call SetDrawInfo for it because it is in transform graph.
Yes, you're right, I missed that it's in a chain of draw transform -> transform -> transformnode. MSDN is broken there, it says interface> Nikolay, do you think I can submit first 3 patches in another MR to make you have a full reviewing in order to upstream them? inherits from IUnknown. That's why I thought it's something special.
I think there are options still, effect can use SetSingleTransformNode to add it explicitly, but I believe I saw examples somewhere that don't do it, so maybe it's handled by d2d itself. I could be wrong of course.
> Nikolay, do you think I can submit first 3 patches in another MR to make you have a full reviewing in order to upstream them?
Please do. We should start with single node graph first to get something render first, and have inputs/outputs behaving correctly. I think doing multiple nodes processing in naive way, by drawing each intermediate step, is likely to be a performance problem.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/635#note_6556
When first parsed to names in english and other non-native languages,
after parsing to names in native languages, this will result in second_name
not corresponding to names in english.
Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com>
--
v7: win32u: Don't allow a replaced font to be a replacement.
win32u: Ensure that either the primary or secondary name is in English.
https://gitlab.winehq.org/wine/wine/-/merge_requests/628
On Fri Aug 19 08:54:40 2022 +0000, Hans Leidekker wrote:
> In the patch title please replace one occurrence of
> kerberos_SpAcceptLsaModeContext with kerberos_SpInitLsaModeContext.
> Otherwise the patch looks good.
Pushed. Sorry, I did not notice a repetition in title.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6535