Made changes to comdlg32/itemdlg.c to add missing controls, which are the address bar and the up button.
Updated bitmaps in comctl32 and SVG files for history icons.
My changes help to resolve this bug: https://bugs.winehq.org/show_bug.cgi?id=50338.
--
v4: comdlg32: Add missing controls and their functionality to IFileDialog, or the common item dialog.
https://gitlab.winehq.org/wine/wine/-/merge_requests/672
When first parsed to names in english and other non-native languages,
after parsing to names in native languages, this will result in second_name
not corresponding to names in english.
Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com>
--
v3: win32u: Fix that the replaced font replaces other fonts.
win32u: Fix the second_name parsed wrong.
https://gitlab.winehq.org/wine/wine/-/merge_requests/628
On Wed Aug 17 06:20:22 2022 +0000, Yeshun Ye wrote:
> I built the demo by vs2003/vs2005/vs2008, and it printed 'read: ok' for
> vs2003 building, but printed 'open file failed!' for vs2005/vs2008
> buildings.
> I think "\_MSVCP_VER >= 71" can change to "\_MSVCP_VER >= 80" at least.
> And I think it's a bug on vs2005/vs2008, do we have to be exactly the
> same as windows? Why do we keep this bug?
I've created MR !673 to fix msvcp71. I've made a mistake while testing it earlier.
The idea is to implement the function as closely to native as possible. Applications may depend on bugs in libraries (and taking into account _Fiopen is an internal function it's not necessarily a bug).
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/606#note_6472
Made changes to comdlg32/itemdlg.c to add missing controls, which are the address bar and the up button.
Updated bitmaps in comctl32 and SVG files for history icons.
My changes help to resolve this bug: https://bugs.winehq.org/show_bug.cgi?id=50338.
--
v3: comdlg32: Add missing controls and their functionality to IFileDialog, or the common item dialog.
https://gitlab.winehq.org/wine/wine/-/merge_requests/672
Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/idb_hist_large.svg:
> -<?xml version="1.0" encoding="UTF-8" standalone="no"?>
> +<?xml version="1.0" encoding="UTF-8"?>
> <!-- Created with Inkscape (http://www.inkscape.org/) -->
> -<svg id="bitmap:120-32" xmlns="http://www.w3.org/2000/svg" height="24" width="120" version="1.1" xmlns:xlink="http://www.w3.org/1999/xlink">
Do not remove the id property. There should be a id="bitmap:width-depth" property for the wine's build system to generate the bitmaps from SVGs.
Also, the commit subject is way too long.
And, for the WineHQ bugzilla link. We use the Wine-Bug: tag.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6461